fix: generate typed css module #534
Open
+861
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trim21 this pull request is now in conflict 😩 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 82.43% 82.43%
=======================================
Files 98 98
Lines 5942 5942
Branches 459 459
=======================================
Hits 4898 4898
Misses 1038 1038
Partials 6 6 ☔ View full report in Codecov by Sentry. |
trim21
commented
Apr 4, 2023
| @@ -9,27 +9,27 @@ import style from './SubMenu.module.less'; | |||
| const buildMenuBottom = (verb: '看' | '读' | '听' | '玩'): MenuItemType[] => [ | |||
| { | |||
| key: 'do', | |||
| className: style['subMenuItem--do'], | |||
There was a problem hiding this comment.
这里之前写的也是错的，目前vite module的设置只会生成camalCase的class name
Preview Deployment
|
Merged
|
@trim21 this pull request is now in conflict 😩 |
mergify
bot
added
ci:lint:fail
and removed
waiting-approval
mergify
bot
added
waiting-approval
|
@trim21 this pull request is now in conflict 😩 |
|
@trim21 this pull request is now in conflict 😩 |
|
@trim21 this pull request is now in conflict 😩 |
|
@trim21 this pull request is now in conflict 😩 |
|
@trim21 this pull request is now in conflict 😩 |
|
@trim21 this pull request is now in conflict 😩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#473 (comment)
不太确定是不是需要
vite dev的情况下会watch*.module.less然后生成对应的.d.ts.试了一下似乎还是得生成
*.module.less.d.ts，生成*.module.d.less.ts并不能被正确识别...这里构建失败是因为之前写的有bug... 这个
editorItemCursor在runtime是不存在的。需要 @FoundTheWOUT 修一下
看来还是有必要的（