adjustments to the negative binomial tutorial - #884
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hey @connor-pph thanks for the PR and suggestions. Briefly looking at the commit, it looks you try to remove the first person point of view and add some (and or reword) sections for clarity? |
|
hey sorry, should have said more in pr summary. I was a bit confused by the intro when working through the notebook and it was helpful for me to frame the difference between modeling failures/trials and where y starts based on that. I had no problem with the first person POV - it would have just felt strange to pretend I was the original author =] And I did a couple small typo's later in the notebook. |
| @@ -18,28 +18,36 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
I would replace "we can use the following definition:" with "the probability mass function (pmf) results:" and directly show the first pmf you list.
Then I find it a bit repetitive that you say twice, and very close, that Y starts at zero when modeling failures, but it's fine.
Reply via ReviewNB
| @@ -18,28 +18,36 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
| @@ -18,28 +18,36 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
|
@connor-pph thanks for the changes. I liked the first person when I wrote it, but I think the modifications are good. I'm asking to update a few things. And I would like to ask to update any outdated link you may find. Thanks! |
hey @tomicapretto - I was working through the negative binomial tutorial (which is great btw!) and was wondering if you'd be open to some edits/adjustments for clarity (in the introduction mostly)