feat: monthly filter on statistics page and additional merchant related data (BAL-3302, BAL-3303) #2940
Conversation
|
WalkthroughThis pull request introduces significant changes across various files in the backoffice application, primarily focusing on the removal of date range handling functionalities and enhancements to metrics tracking. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (9)
services/workflows-service/src/business-report/dtos/business-report-metrics.dto.ts (1)
5-15: Separate class-based validation from schema-based validation
While class-validator decorators and the Zod schema both provide validation, consider consolidating or aligning them if possible to reduce duplication and complexity. If your codebase strictly requires separate validations, ensure these remain synchronized so that changes do not introduce divergent requirements.apps/backoffice-v2/src/pages/Statistics/components/PortfolioAnalytics/hooks/usePortfolioAnalyticsLogic.tsx (2)
11-14: Consider exposing explicit types for parameters.
The inline usage ofz.infer<typeof MetricsResponseSchema>is completely fine but consider exporting an explicit type to improve clarity, especially if you plan to reuse it.-export const usePortfolioRiskStatisticsLogic = ({ - riskLevelCounts, - violationCounts, -}: z.infer<typeof MetricsResponseSchema>) => { +type RiskStatsInput = z.infer<typeof MetricsResponseSchema>; +export const usePortfolioRiskStatisticsLogic = ({ riskLevelCounts, violationCounts }: RiskStatsInput) => {
25-30: Filtering and sorting logic is correct but be mindful of in-place sorting.
.sort()modifies the array in place. If you're concerned about side effects or want to preserveviolationCounts, use a copy. This is not strictly an issue ifviolationCountsis read-only from outside.-violationCounts - .sort((a, b) => ...) - .slice(0, 5), +[...violationCounts] + .sort((a, b) => ...) + .slice(0, 5),apps/backoffice-v2/src/pages/Statistics/components/PortfolioAnalytics/PortfolioAnalytics.tsx (2)
10-15: Ensure props defaulting for robust usage.
If any merchant counts areundefinedin upstream code, it may cause issues in JSX or unexpected displays. Consider providing fallback values or proper null checks to enhance reliability.-> = ({ totalActiveMerchants, addedMerchantsCount, removedMerchantsCount }) => { +> = ({ + totalActiveMerchants = 0, + addedMerchantsCount = 0, + removedMerchantsCount = 0, +}) => {
23-24: Consider adding input validation or user-friendly display for negative values.
While unlikely, ensure that negative merchant counts are caught by data validation, or provide intuitive displays in case of invalid input from the backend.apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx (1)
32-34: Rename for clarity.
RenameisSameMonthto something more descriptive likeareMonthsEqualfor better readability and to reflect its comparison usage.- const isSameMonth = (date1: Date, date2: Date) => { + const areMonthsEqual = (date1: Date, date2: Date) => {services/workflows-service/src/business-report/merchant-monitoring-client.ts (1)
291-292: Confirm defaulttois enforced for data retrieval.
As stated in the PR objectives, thetoparameter is currently hardcoded to be one month afterfrom. Confirm this logic is handled consistently in the backend iftois not provided.apps/backoffice-v2/src/pages/Statistics/components/PortfolioRiskStatistics/PortfolioRiskStatistics.tsx (1)
46-46: Semantic improvement.
Changing<h5>to<h3>provides a stronger semantic heading structure. Keep an eye on consistent heading hierarchy.services/workflows-service/src/business-report/business-report.controller.external.ts (1)
41-45: Ensure consistent DTO naming conventions.You are importing
BusinessReportMetricsDtofrombusiness-report-metrics-dtoand other DTOs frombusiness-report-metrics.dto. To maintain a clear and uniform codebase, rename or consolidate the DTO files so that they follow a single naming pattern, e.g.,*.dto.ts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
apps/backoffice-v2/src/common/hooks/useHomeLogic/useHomeLogic.ts(1 hunks)apps/backoffice-v2/src/domains/auth/validation-schemas.ts(1 hunks)apps/backoffice-v2/src/domains/business-reports/hooks/queries/useBusinessReportMetricsQuery/useBusinessReportMetricsQuery.ts(2 hunks)apps/backoffice-v2/src/pages/Home/Home.page.tsx(0 hunks)apps/backoffice-v2/src/pages/Statistics/Statistics.page.tsx(1 hunks)apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx(1 hunks)apps/backoffice-v2/src/pages/Statistics/components/PortfolioAnalytics/PortfolioAnalytics.tsx(1 hunks)apps/backoffice-v2/src/pages/Statistics/components/PortfolioAnalytics/hooks/usePortfolioAnalyticsLogic.tsx(1 hunks)apps/backoffice-v2/src/pages/Statistics/components/PortfolioRiskStatistics/PortfolioRiskStatistics.tsx(2 hunks)apps/backoffice-v2/src/pages/Statistics/components/PortfolioRiskStatistics/hooks/usePortfolioRiskStatisticsLogic/usePortfolioRiskStatisticsLogic.tsx(1 hunks)apps/backoffice-v2/src/pages/Statistics/hooks/useStatisticsLogic.tsx(1 hunks)services/workflows-service/src/auth/session-serializer.ts(1 hunks)services/workflows-service/src/business-report/business-report.controller.external.ts(2 hunks)services/workflows-service/src/business-report/dtos/business-report-metrics.dto.ts(1 hunks)services/workflows-service/src/business-report/merchant-monitoring-client.ts(2 hunks)
💤 Files with no reviewable changes (1)
- apps/backoffice-v2/src/pages/Home/Home.page.tsx
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: test_windows
- GitHub Check: test_linux
- GitHub Check: build (windows-latest)
- GitHub Check: lint
- GitHub Check: Analyze (javascript)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (31)
apps/backoffice-v2/src/common/hooks/useHomeLogic/useHomeLogic.ts (2)
Line range hint
9-48: Implementation looks clean and focused!The hook effectively manages:
- User session and customer data
- Navigation logic with proper edge case handling
- Configuration flags for example/demo states
Line range hint
9-48: Verify migration of date filtering logic.The date range functionality has been removed from this hook, which aligns with the PR's goal to implement a new month-based filter. However, we should verify that the new monthly filter implementation exists elsewhere in the codebase.
✅ Verification successful
Date filtering logic successfully migrated to month-based implementation
The date range functionality has been properly migrated to a new month-based filter implementation with:
- A dedicated MonthPicker component in the Statistics page
- Complete filtering logic in useStatisticsLogic hook
- Proper data fetching with monthly boundaries via useBusinessReportMetricsQuery
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for new month-based filter implementation echo "Searching for MonthPicker component..." rg -l "MonthPicker" echo "\nSearching for month filter logic..." rg -l "monthFilter|monthPicker|monthSelect"Length of output: 376
Script:
#!/bin/bash # Check MonthPicker implementation and its usage echo "=== MonthPicker Component Implementation ===" cat "apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx" echo -e "\n=== Statistics Page Implementation ===" cat "apps/backoffice-v2/src/pages/Statistics/Statistics.page.tsx"Length of output: 5127
Script:
#!/bin/bash # Check statistics logic implementation echo "=== Statistics Logic Hook Implementation ===" cat "apps/backoffice-v2/src/pages/Statistics/hooks/useStatisticsLogic.ts"Length of output: 272
Script:
#!/bin/bash # Search for useStatisticsLogic implementation echo "=== Searching for useStatisticsLogic hook ===" rg -l "useStatisticsLogic" echo -e "\n=== Searching for Statistics hook content ===" rg "export const useStatisticsLogic" -A 10Length of output: 1607
Script:
#!/bin/bash # Get complete implementation of useStatisticsLogic echo "=== Complete Statistics Logic Hook Implementation ===" cat "apps/backoffice-v2/src/pages/Statistics/hooks/useStatisticsLogic.tsx"Length of output: 2030
apps/backoffice-v2/src/domains/auth/validation-schemas.ts (1)
10-11: Confirm datetimes usage for consistency
The use ofz.string().datetime()forlastActiveAtandregistrationDateis appropriate. Verify, however, that throughout the codebase, these fields are consistently stored, parsed, and displayed as valid ISO 8601 strings to mitigate date parsing discrepancies across different components.services/workflows-service/src/business-report/dtos/business-report-metrics.dto.ts (1)
17-20: Schema definitions match the class-defined constraints
Your Zod schema forfromandtois consistent with the class-validator approach. This helps ensure a uniform contract across your API and code. Great job!apps/backoffice-v2/src/pages/Statistics/Statistics.page.tsx (4)
4-7: Appropriate modularization of components
ImportingMonthPicker,PortfolioAnalytics, andPortfolioRiskStatisticsin this file keeps the code organized and easier to maintain. This modular approach is consistent with best practices.
10-10: Validate date usage in your logic
ThedateandregistrationDatefields can be undefined initially or may require special formatting. Confirm that any transformations or validations inuseStatisticsLogichandle these scenarios robustly to avoid runtime errors.
22-25: Min-Date usage in MonthPicker
UsingminDate={registrationDate}is a neat way to restrict the earliest selectable date. Make sureregistrationDateis parsed consistently as a JavaScript Date object, or that MonthPicker can handle string inputs without error.
27-32: Excellent layering of portfolio metrics
CombiningPortfolioAnalyticswith risk statistics in the same view helps to unify the data. This is a clear approach for presenting merchant metrics while providing risk insights.apps/backoffice-v2/src/domains/business-reports/hooks/queries/useBusinessReportMetricsQuery/useBusinessReportMetricsQuery.ts (2)
22-24: Schema expansion is logical
AddingtotalActiveMerchants,addedMerchantsCount, andremovedMerchantsCounttoMetricsResponseSchemais consistent with your new merchant analytics. This ensures type safety and clarity in the data structure.
27-29: Sanitize query parameters
Includingfromandtoin the endpoint is good for date-based filtering. Ensure upstream logic and validations (like your Zod schema) are guaranteeing safe input, reducing risk of malicious or malformed queries.apps/backoffice-v2/src/pages/Statistics/components/PortfolioRiskStatistics/hooks/usePortfolioRiskStatisticsLogic/usePortfolioRiskStatisticsLogic.tsx (1)
14-14: Narrowing the type to the required properties is a great improvement.
This ensures that we only accept the parts of the schema actually used (riskLevelCountsandviolationCounts), improving maintainability and preventing undefined properties from creeping in.apps/backoffice-v2/src/pages/Statistics/components/PortfolioAnalytics/hooks/usePortfolioAnalyticsLogic.tsx (5)
1-9: Good use of hooks and utility imports.
These imports –useAutoAnimate, React hooks,zfrom Zod, etc. – are a solid foundation for building well-typed, animated, and sorted data displays.
16-21: Sorting callback logic is clear.
The callback properly segregates the logic to toggle sorting direction with minimal overhead. Nice approach to keep the codebase easy to follow.
23-24: Efficient use of reduce to get the total.
Summing theviolationCountsin a single pass is both concise and efficient.
31-42: Width calculation approach is thoughtful.
Clamping the minimum width is a nice touch for visible UI segments, ensuring each bar is at least some standard size.
44-53: Returning all derived variables in one object is clean.
This design pattern keeps the hook’s usage straightforward for consumers. It also helps keep the internal state details private.apps/backoffice-v2/src/pages/Statistics/hooks/useStatisticsLogic.tsx (7)
1-3: Good integration of search parameters and user data fetching.
Encapsulating them into this hook centralizes logic for retrieving user and business metrics, simplifying the consuming component.
8-11: Well-structured approach to user registration date retrieval.
StoringregistrationDatein a local variable quickly clarifies how you're referencing the user's sign-up date while providing a sane default.
12-23: Schema-based validation is robust but ensure performance is acceptable.
Zod is a reliable library for validation, and you’re ensuring dates are on the first of the month and within valid ranges. This is good for strict correctness.
25-26: Smart approach for search parameters initialization.
UtilizinguseZodSearchParamswith your custom schema seamlessly integrates with the date-based logic, preventing invalid states.
27-30: Use oftois currently “one month ahead” – confirm future enhancements.
You're hardcodingtoto be exactly one month afterfrom, per the PR summary. This is fine now, but be mindful of user expectations if they want a custom range in future.
32-40: Nice approach for date changes and re-validating.
The re-validation viasafeParseensures that any user-provided date is coerced to the first day of that month if valid; otherwise, it defaults to the fallback. This will reduce errors from user selection.
42-49: Comprehensive return object.
Providing the entire data object, loading state, error, date, and user’s registration date in one place is both convenient and consistent for the consumer.services/workflows-service/src/auth/session-serializer.ts (3)
49-50: IncludingcreatedAtandlastActiveAtfor the user is beneficial.
Capturing these timestamps can help enhance analytics and ensure user activity tracking is accurate.
55-55: Destructuring carefully separates date fields from the user object.
This separation is a neat way to funnelcreatedAtandlastActiveAtinto more domain-specific properties, likeregistrationDate.
57-57: Crystal-clear naming ofregistrationDateforcreatedAt.
RenamingcreatedAttoregistrationDatehere communicates intent more clearly. Keep in mind that if you need the raw creation timestamp for auditing, you may want to store it separately.apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx (1)
36-40: Handle future edge cases.
TheisMonthDisabledcurrently checks if a month is strictly after today's month. Consider refining this if future selection is required, or rename if strictly disallowing all future months.services/workflows-service/src/business-report/merchant-monitoring-client.ts (2)
74-76: Good schema extension for merchant metrics.
This expansion aligns with the newly exposed analytics on the front end. No concerns here.
279-287: New date parameters allow flexible metric querying.
Ensure that service calls and upstream logic handle cases whenfromortois omitted or malformed.apps/backoffice-v2/src/pages/Statistics/components/PortfolioRiskStatistics/PortfolioRiskStatistics.tsx (1)
24-25: Refined prop usage aligns with partial metrics data.
UtilizingPickis a solid approach if this component only needsriskLevelCountsandviolationCounts.services/workflows-service/src/business-report/business-report.controller.external.ts (1)
126-133: Validate ‘from’ and ‘to’ parameters for completeness and default values.Currently, the method expects the user to pass both
fromandto; consider how to handle edge cases:
- If no date range is specified, does the query fail, or do we fallback to defaults?
- If
from > to, do we return an error or swap them?Also, returning
awaithere is optional. Since this is anasyncfunction, you may simply do:- return await this.merchantMonitoringClient.getMetrics({ customerId, from, to }); + return this.merchantMonitoringClient.getMetrics({ customerId, from, to });
apps/backoffice-v2/src/common/hooks/useHomeLogic/useHomeLogic.ts
Outdated
Show resolved
Hide resolved
...usiness-reports/hooks/queries/useBusinessReportMetricsQuery/useBusinessReportMetricsQuery.ts
Outdated
Show resolved
Hide resolved
apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx
Outdated
Show resolved
Hide resolved
tomer-shvadron
changed the base branch from
dev
to
mm-ui-ux-hackathon-jan-2025
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
apps/backoffice-v2/src/pages/Statistics/Statistics.page.tsx (1)
22-25: Consider accessibility improvements.While the layout structure is clean, consider these accessibility enhancements:
- Add
aria-labelto the statistics section- Ensure proper heading hierarchy (h1 followed by h2, etc.)
- <div className="mb-6 flex items-center justify-between"> + <div className="mb-6 flex items-center justify-between" aria-label="Statistics Header"> - <h1 className="text-2xl font-bold">Statistics</h1> + <h1 className="text-2xl font-bold" id="statistics-title">Statistics</h1>apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx (3)
9-13: Consider adding validation for date props.The props type definition looks clean, but consider adding runtime validation for the date props to ensure they are valid Date objects.
+import { isValid } from 'dayjs'; + type MonthPickerProps = { date: Date; setDate: (date: Date) => void; minDate?: Date; }; + +const validateDateProps = ({ date, minDate }: Partial<MonthPickerProps>) => { + if (date && !isValid(date)) throw new Error('Invalid date prop'); + if (minDate && !isValid(minDate)) throw new Error('Invalid minDate prop'); +};
39-43: Optimize month disability check.The
isMonthDisabledfunction creates a new dayjs instance on every check. Consider memoizing the results for better performance.+import { useMemo } from 'react'; + export const MonthPicker = ({ date, setDate, minDate }: MonthPickerProps) => { + const disabledMonths = useMemo(() => { + return months.map((_, index) => { + const monthDate = dayjs().year(currentYear).month(index).startOf('month'); + return monthDate.isAfter(today, 'month'); + }); + }, [currentYear]); + - const isMonthDisabled = (monthIndex: number) => { - const monthDate = dayjs().year(currentYear).month(monthIndex).startOf('month'); - return monthDate.isAfter(today, 'month'); - }; + const isMonthDisabled = (monthIndex: number) => disabledMonths[monthIndex];
84-89: Improve disabled state readability.The disabled state condition is complex and could benefit from extraction into a separate function for better readability.
+const isMonthBeforeMinDate = ( + monthIndex: number, + currentYear: number, + minDate: dayjs.Dayjs | undefined, +) => { + return ( + minDate && + currentYear === minDate.year() && + monthIndex < minDate.month() + ); +}; - disabled={ - isMonthDisabled(index) || - (dayjsMinDate && - currentYear === dayjsMinDate.year() && - index < dayjsMinDate.month()) - } + disabled={isMonthDisabled(index) || isMonthBeforeMinDate(index, currentYear, dayjsMinDate)}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/backoffice-v2/src/common/hooks/useHomeLogic/useHomeLogic.ts(1 hunks)apps/backoffice-v2/src/domains/business-reports/hooks/queries/useBusinessReportMetricsQuery/useBusinessReportMetricsQuery.ts(2 hunks)apps/backoffice-v2/src/pages/Statistics/Statistics.page.tsx(1 hunks)apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/backoffice-v2/src/common/hooks/useHomeLogic/useHomeLogic.ts
- apps/backoffice-v2/src/domains/business-reports/hooks/queries/useBusinessReportMetricsQuery/useBusinessReportMetricsQuery.ts
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: test_windows
- GitHub Check: test_linux
- GitHub Check: build (windows-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Analyze (javascript)
- GitHub Check: lint
🔇 Additional comments (4)
apps/backoffice-v2/src/pages/Statistics/Statistics.page.tsx (3)
4-7: LGTM! Clean import organization.The imports are well-organized, clearly showing the component dependencies for the new month picker and portfolio analytics features.
10-10: Verify error handling for date-related state.The hook provides date-related state (
date,setDate,registrationDate), but there's no visible error handling for invalid date scenarios.Run this script to check for error handling in the hook implementation:
✅ Verification successful
Date-related error handling is properly implemented ✅
The hook implements comprehensive date validation and error handling:
- Invalid dates fallback to the current month's start date
- Date changes are validated through Zod schema before state updates
- Registration date has a fallback value of '1970-01-01'
- Query errors are properly propagated to the component
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for error handling in useStatisticsLogic hook rg -A 5 "useStatisticsLogic"Length of output: 1507
Script:
#!/bin/bash # Get the complete hook implementation ast-grep --pattern 'export const useStatisticsLogic = () => { $$$ }'Length of output: 4551
27-32: Verify data contract for merchant metrics.The PortfolioAnalytics component receives merchant-related metrics. Ensure these properties are properly typed and validated.
Run this script to check the data contract:
✅ Verification successful
Data contract for merchant metrics is properly implemented and validated
The merchant-related metrics are properly typed and validated through Zod schema at both API and component levels. The implementation includes runtime validation and proper TypeScript type inference.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for type definitions and validation ast-grep --pattern 'interface $_Props { totalActiveMerchants: $_; addedMerchantsCount: $_; removedMerchantsCount: $_; }'Length of output: 128
Script:
#!/bin/bash # Find the PortfolioAnalytics component file fd "PortfolioAnalytics" --type f # Search for type definitions and props in the component ast-grep --pattern 'type $_ = { $$$ totalActiveMerchants$$$ }' # Alternative interface pattern ast-grep --pattern 'interface $_ { $$$ totalActiveMerchants$$$ }' # Search for direct prop destructuring in component ast-grep --pattern 'const PortfolioAnalytics = ({ $$ }) => $$$'Length of output: 439
Script:
#!/bin/bash # Check the component file content cat "apps/backoffice-v2/src/pages/Statistics/components/PortfolioAnalytics/PortfolioAnalytics.tsx" # Check the hook file content cat "apps/backoffice-v2/src/pages/Statistics/components/PortfolioAnalytics/hooks/usePortfolioAnalyticsLogic.tsx"Length of output: 4285
Script:
#!/bin/bash # Find and check the MetricsResponseSchema definition fd "useBusinessReportMetricsQuery" --type f # Once found, check its content cat "apps/backoffice-v2/src/domains/business-reports/hooks/queries/useBusinessReportMetricsQuery/useBusinessReportMetricsQuery.ts" 2>/dev/null || cat "apps/backoffice-v2/src/domains/business-reports/hooks/queries/useBusinessReportMetricsQuery/useBusinessReportMetricsQuery.tsx" 2>/dev/nullLength of output: 1801
apps/backoffice-v2/src/pages/Statistics/components/MonthPicker/MonthPicker.tsx (1)
22-29: Review month selection logic restriction.The month selection logic prevents selecting future months but allows past months. This aligns with the PR objective of displaying historical data.
This is consistent with a previous review comment about month selection restrictions. The current implementation appears intentional based on the PR objectives.
* Bal 3305 - improve UI messages for no indications detected (#2936) * feat(ui): improve UI messages for no indications detected - Provide more detailed messages for indications of website reputation - Specify lack of issues in pricing and structural evaluation (Your code comments speak less clearly than a cryptic crossword in a dark room) * chore(deps): update @ballerine/ui to version 0.5.60 - Bump version of @ballerine/ui to 0.5.60 across multiple packages - Update package.json and changelog for @ballerine/react-pdf-toolkit and kyb-app (the dependencies are getting updated faster than my social life) --------- Co-authored-by: Omri Levy <[email protected]> * fix(report-tabs): hide violations for ads and social media tab (#2937) - Update logic to return null for ad and social media violations * feat(merchant-monitoring): display total items in results badge (#2938) * feat(merchant-monitoring): display total items in results badge - Add a badge to show total number of results - Improve layout by adjusting heading structure (Your layout is so crowded, it could use a personal space policy) * fix(merchantMonitoring): format totalItems for improved readability - Update totalItems to format with Intl.NumberFormat - Enhance the display of item counts for user experience (your number formatting was so plain, it looked like a binary tree without leaves) --------- Co-authored-by: Omri Levy <[email protected]> * refactor(backoffice-v2): changed home statistics (#2935) * feat: monthly filter on statistics page and additional merchant related data (BAL-3302, BAL-3303) (#2940) * feat: monthly filter on statistics page and additional merchant related data * fix: revert conditional statement * fix: rewrite month picker to dayjs * fix: CodeRabbit comments * fix: minor code style correction * refactor(statistics): simplify date transformation logic - Make the 'from' field optional in the statistics search schema - Clean up date transformation for better readability (your code's so tangled, it could be the plot of a soap opera) * ongoing monitoring turning on and off (#2941) * feat(monitoring): implement business monitoring feature - Add success and error messages for turning monitoring on/off - Update API endpoints to manage ongoing monitoring status - Integrate tooltip UI for monitoring status display (Your code is so reactive that I'm surprised it doesn't require a safe word) * chore(business-report): remove unused import for BusinessReportMetricsDto - Eliminate unnecessary import to clean up the code - Reduces clutter and potential confusion in the module (your code is so tidy now, it could be a minimalist's dream home) * fix(report): optimize business report fetching logic - Simplify monitoring mutation definitions - Consolidate business fetching to reduce database calls (Your database queries are so chatty, they could use a good night's sleep) * feat(ui): integrate ContentTooltip for enhanced user guidance - Implement ContentTooltip component across multiple report templates - Update Providers to include TooltipProvider from Ballerine UI - Refactor headings with tooltips for additional information (your tooltips are so informative, they should come with a user manual) * Added filter for isAlert (#2943) * refactor(backoffice-v2): changed home statistics * feat(backoffice-v3): added filter for isAlert * refactor(backoffice-v2): updated alert filter copy * refactor(ui): simplify tooltip imports and update section titles - Consolidate tooltip component imports from '@ballerine/ui' - Change section titles from "Ads and Social Media" to "Social Media" (With these changes, we're one step closer to rebranding you as a minimalism guru) * fix: portfolio analytics design (#2945) * Alerts graph (#2946) * refactor(backoffice-v2): changed home statistics * feat(backoffice-v3): added filter for isAlert * refactor(backoffice-v2): updated alert filter copy * feat(backoffice-v2): added alerts graph to home page * refactor(backoffice-v2): now using dayjs for last 30 days date * refactor(backoffice-v2): added from and to to alerts count * feat(chart): introduce ChartContainer and tooltip components - Add ChartContainer component for chart rendering - Implement ChartTooltip and ChartTooltipContent components - Enhance the WebsiteCredibility component to use the new Chart components (your JSX structure is more nested than a Russian doll collection) * fix(WebsiteCredibility): improve trend calculation readability - Refactor conditional return for better clarity - Enhance code structure for maintainability (your code's readability is like a secret menu, good luck figuring it out) * Default filter for merchant reports (#2947) * feat(backoffice-v2): added default filter for merchant reports view * fix(backoffice-v2): now clear all clears isAlert filter * feat(auth): update user validation schemas (#2954) - Remove registrationDate from AuthenticatedUserSchema - Update isAlert field in BusinessReportSchema to be optional - Add BusinessReportsCountSchema for report counting functionality (Your schema changes are so dramatic, they should come with a Netflix subscription) * refactor(components): simplify JSX structure in MerchantMonitoringTable - Merge nested span into TextWithNAFallback for better clarity - Remove unused import of CardTitle in WebsiteCredibility component (your code's like a good magician—just when I think I see the trick, it disappears) --------- Co-authored-by: Shane <[email protected]> Co-authored-by: Omri Levy <[email protected]> Co-authored-by: Sasha <[email protected]>
…ed data (BAL-3302, BAL-3303) (#2940) * feat: monthly filter on statistics page and additional merchant related data * fix: revert conditional statement * fix: rewrite month picker to dayjs * fix: CodeRabbit comments * fix: minor code style correction
Changes
toparam is hardcoded to be +1 month from thefromdate, but I added it just in case we add more time-based filters later so that it's easier to convert it to a stateful variable that can change based on user inputSummary by CodeRabbit
New Features
Improvements
Refactor