Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bal 1644 - report in case management #2343
Bal 1644 - report in case management #2343
Changes from 69 commits
a229547
6fe5693
1888d2e
d657ee4
2c03c6e
fa0dd21
e849d29
9de6f37
35abd78
89d3169
fa8935c
cfe515d
dc05878
924ccaf
0d1ed0b
76cefc9
549cb7d
1d15b8c
e72ae5f
203f583
0af4256
5c21784
8d32745
8344bf7
1e976f2
7b6347d
51cfc96
b5f36b4
ae9c95f
a8e1a1b
8ed47e5
ba93150
9f8d3c5
7c4055a
a6eca5b
13f68bb
e2f6810
610d9f7
36361bc
55cfca6
4828e8c
ca2c60e
7b672f3
b19d4a7
3fee08e
2c43c5d
5e7d0da
9b843c2
41ce263
11dd0f5
4cb5e8e
49ec5b6
6b303a9
4d68f6a
abcb568
e4edf2c
5a309a3
f14efa1
07be97d
0dc86f6
d73bcb0
7bf63b7
7fb50ab
ff572dc
6a1cc16
1f65d71
6e0bf69
6da9f1d
5b8e07f
ce8bf38
7443d11
5181498
066f538
4a34fe1
26aefad
b1e4392
d0844c9
bce1800
330341d
7ef11bb
33be864
ab45535
a0f7969
6f4b1aa
f074b33
30ac7f4
b721fa6
5fca5b1
e0df50f
9452a57
419de02
05aaf9e
8747e79
2a47598
fcbcca3
2030bdb
c446fc8
5b02205
48bf1d3
410de81
45f1ebb
521c48f
c6c998d
ced6237
4d9660b
842ac68
6aaceaf
fb9810b
c6a0f23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The route for
TransactionMonitoringAlerts
has been duplicated.Ensure that the correct component is used for the route.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug logging to clean up the code.
- console.log('title', { title });
Removing debug statements from production code helps in keeping the codebase clean and secure.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this? Why was this needed, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case if custom styles or
React.Node
will be needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will get considerably more value by using something like
as
orasChild
or justchildren
and passingclassName
intoctw
. Changing the markup depending on string to me is unpredictable. Otherwise if we make a re-usable filters component the heading will probably be a part of it and won't be elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the
defaultValue
inIFilterDefinition
is typed based onTFilterParams
to enhance type safety.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The verification of the
onChange
callback usage inIFilterInputParams
across the application shows a variety of implementations and expected types. The callback is used in multiple components and contexts, often with different parameter types such asstring
,number
, arrays, or even more complex objects. This diversity in usage suggests that the type definition inIFilterInputParams
might not be sufficiently generic or flexible to cover all use cases observed.Given the variety of
onChange
implementations, it would be prudent to either:IFilterInputParams
to be more inclusive or generic.onChange
usage that deviate from the defined type are intentional and correctly handled.Here are some specific instances where the
onChange
type might need review or adjustment:DynamicForm.tsx
,onChange
is used with the type(formData: TFormData) => void;
.DropdownInput.tsx
,onChange
is defined as(value: string, inputName: string) => void;
.FacetedFilter.tsx
,onChange
is used with the type(values: string[]) => void;
.These examples indicate that the type definition of
onChange
inIFilterInputParams
as(value: Array<string | null>) => void;
might not be universally applicable or might require refinement to accommodate various usage contexts.Analysis chain
Clarify the expected type for the
onChange
callback inIFilterInputParams
to ensure it aligns with the actual usage in the application.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 66
Script:
Length of output: 32699
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a more specific type than
unknown
forvalues
inIFiltersProps
to improve type safety.