Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclusive logging for important stuff #1688

Merged

Conversation

liorzam
Copy link
Collaborator

@liorzam liorzam commented Nov 25, 2023

Description

  • We would like to stop toasing not relevant notifications like Unauthorized error

  • We started to log our Axios fetch request

    • Will intercept http service

    • Api plugin

    • Saleforce plugin

  • Workflow Service

    • Every-time our backend couldn't fetch an http route url remotely, the server thrown 500 status code instead of 404

    • We would like reduce redundant:

      ** Logs for incoming request

      ** Min log level for application logger

      ** Stop log none important responses for (401/404 status codes)

Related issues

https://linear.app/ballerine/issue/BAL-888/remove-redundant-toast-in-backoffice-and-better-logging

Copy link

changeset-bot bot commented Nov 25, 2023

⚠️ No Changeset found

Latest commit: 77d9db1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ballerine-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 11:28am

Copy link

sweep-ai bot commented Nov 25, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@liorzam liorzam requested a review from Omri-Levy December 18, 2023 08:17
@liorzam
Copy link
Collaborator Author

liorzam commented Dec 18, 2023

In order to solve the test issues you can follow this link which specify what actually have done in order to fix those tests:

https://stackoverflow.com/questions/76491001/unit-testing-services-that-use-httpmodule/77676262#77676262

Copy link
Contributor

@Omri-Levy Omri-Levy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liorzam liorzam merged commit 8f897ea into dev Dec 18, 2023
9 checks passed
@liorzam liorzam deleted the bal-888-remove-redundant-toast-in-backoffice-and-better-logging branch December 18, 2023 13:07
@Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants