-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exclusive logging for important stuff #1688
feat: exclusive logging for important stuff #1688
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apply Sweep Rules to your PR?
|
...ns/workflows/hooks/mutations/useUpdateWorkflowByIdMutation/useUpdateWorkflowByIdMutation.tsx
Outdated
Show resolved
Hide resolved
...ns/workflows/hooks/mutations/useUpdateWorkflowByIdMutation/useUpdateWorkflowByIdMutation.tsx
Outdated
Show resolved
Hide resolved
services/workflows-service/src/common/filters/AllExceptions.filter.ts
Outdated
Show resolved
Hide resolved
services/workflows-service/src/common/filters/session-exception.filter.ts
Outdated
Show resolved
Hide resolved
In order to solve the test issues you can follow this link which specify what actually have done in order to fix those tests: |
services/workflows-service/src/providers/file/file-provider/http-file.service.ts
Show resolved
Hide resolved
services/workflows-service/src/common/http-service/http-config.service.ts
Show resolved
Hide resolved
Co-authored-by: Omri Levy <[email protected]>
Co-authored-by: Omri Levy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We would like to stop toasing not relevant notifications like Unauthorized error
We started to log our Axios fetch request
Will intercept http service
Api plugin
Saleforce plugin
Workflow Service
Every-time our backend couldn't fetch an http route url remotely, the server thrown 500 status code instead of 404
We would like reduce redundant:
** Logs for incoming request
** Min log level for application logger
** Stop log none important responses for (401/404 status codes)
Related issues
https://linear.app/ballerine/issue/BAL-888/remove-redundant-toast-in-backoffice-and-better-logging