fix: pr comments

ballerine-io · Mar 11, 2024 · ee96e4a · ee96e4a
1 parent 9d62068
commit ee96e4a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/services/workflows-service/src/common/filters/HttpExceptions.filter.ts b/services/workflows-service/src/common/filters/HttpExceptions.filter.ts
@@ -1,6 +1,7 @@
 import { ArgumentsHost, Catch, HttpException, HttpStatus } from '@nestjs/common';
 import { BaseExceptionFilter, HttpAdapterHost } from '@nestjs/core';
 import { Prisma } from '@prisma/client';
+import { PRISMA_UNIQUE_CONSTRAINT_ERROR } from '@/prisma/prisma.util';
 
 export type ErrorCodesStatusMapping = {
   [key: string]: number;
@@ -43,8 +44,7 @@ export class HttpExceptionFilter extends BaseExceptionFilter {
     if (host.getType() === 'http') {
       // for http requests (REST)
       // Todo : Add all other exception types and also add mapping
-      if (exception.code === 'P2002') {
-        // Handling Unique Key Constraint Violation Error
+      if (exception.code === PRISMA_UNIQUE_CONSTRAINT_ERROR) {
         const fields = (exception.meta as { target: string[] }).target;
         message = `Another record with the requested (${fields.join(', ')}) already exists`;
       } else {

diff --git a/services/workflows-service/src/prisma/prisma.util.ts b/services/workflows-service/src/prisma/prisma.util.ts
@@ -2,6 +2,7 @@ import { Prisma } from '@prisma/client';
 
 export const PRISMA_RECORD_NOT_FOUND_ERROR = 'P2025';
 export const PRISMA_FOREIGN_KEY_CONSTRAINT_ERROR = 'P2003';
+export const PRISMA_UNIQUE_CONSTRAINT_ERROR = 'P2002';
 
 export const isRecordNotFoundError = (
   error: unknown,

diff --git a/services/workflows-service/src/transaction/transaction.service.ts b/services/workflows-service/src/transaction/transaction.service.ts
@@ -8,6 +8,7 @@ import { TProjectId } from '@/types';
 import { TransactionCreatedDto } from '@/transaction/dtos/transaction-created.dto';
 import { Prisma } from '@prisma/client';
 import { SentryService } from '@/sentry/sentry.service';
+import { PRISMA_UNIQUE_CONSTRAINT_ERROR } from '@/prisma/prisma.util';
 
 @Injectable()
 export class TransactionService {
@@ -44,7 +45,10 @@ export class TransactionService {
       } catch (error) {
         let errorToLog: Error = new Error('Unknown error', { cause: error });
 
-        if (error instanceof Prisma.PrismaClientKnownRequestError && error.code === 'P2002') {
+        if (
+          error instanceof Prisma.PrismaClientKnownRequestError &&
+          error.code === PRISMA_UNIQUE_CONSTRAINT_ERROR
+        ) {
           errorToLog = new Error('Transaction already exists', { cause: error });
         } else {
           this.sentry.captureException(errorToLog);