os.getAvailableOsVersions: Add support for providing additional pine options #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
changed the title
thgreasi
commented
Jan 15, 2025
| ): Promise<Dictionary<OsVersion[]>> => { | ||
| const hostapps = await _getOsVersions(deviceTypes, options); | ||
| const extraFilterOptions = |
There was a problem hiding this comment.
primarily just moved from bellow and replaced the === 'all check with convenienceFilter === 'supported' || convenienceFilter === 'include_draft' to be more specific.
thgreasi
force-pushed
the
getAvailableOsVersions-pineOptons
branch
from
78b2404 to
bffbe05
Compare
thgreasi
force-pushed
the
getAvailableOsVersions-pineOptons
branch
from
bffbe05 to
4304cd1
Compare
thgreasi
force-pushed
the
getAvailableOsVersions-pineOptons
branch
from
4304cd1 to
2e740aa
Compare
…options Change-type: minor
thgreasi
force-pushed
the
getAvailableOsVersions-pineOptons
branch
from
2e740aa to
c00e677
Compare
myarmolinsky
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor
Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch
Contributor checklist