-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update weather app #75
Open
gantonayde
wants to merge
9
commits into
balena-io-experimental:master
Choose a base branch
from
gantonayde:update-weather-app
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update weather app #75
gantonayde
wants to merge
9
commits into
balena-io-experimental:master
from
gantonayde:update-weather-app
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make weather icons use a palette of 3 colours.
Add COLOUR variable if the display supports a third colour.
User can set a variable above which T will be shown in colour if the display supports it.
Only for WAVESHARE and WEATHER_INVERT
Add X_OFFSET and Y_OFFSET to text. Increase text font size by 2.
gantonayde
force-pushed
the
update-weather-app
branch
5 times, most recently
from
October 11, 2022 07:33
8507157
to
d0e37c8
Compare
Swap the black and colour pixels of night weather icons. Add `DARK_MODE` as environment variable. It swaps black and white pixels of the final image. Make weather text scaling and icon positioning based on display height. Make swap colours False by defualt. Fix 02d.png and 02n.png position for small screens. Limit dark mode to weather mode. Update README. Switch to flowzone. Change-type: minor Signed-off-by: Genadi Naydenov <[email protected]>
gantonayde
force-pushed
the
update-weather-app
branch
from
October 11, 2022 09:38
d0e37c8
to
965865a
Compare
Add repo.yml
gantonayde
force-pushed
the
update-weather-app
branch
from
October 11, 2022 09:46
dd39157
to
09c70d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DARK_MODE
as environment variable. It swaps black and white pixels on the final image.Change-type: minor
Signed-off-by: Genadi Naydenov [email protected]