Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to be working on socket.io-client v4.7.5 #132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

craigvantonder
Copy link

@craigvantonder craigvantonder commented Jun 16, 2024

Incorporates PR-131 whilst adding another change that I ran into when testing with [email protected]

Tried to get the tests to pass but it seems there is an issue, atleast on my system, with phantomjs. So I worked around that and ran into another test issue where it fails on queueing -> requests -> after reconnecting socket

1) queueing ::  requests ::  after reconnecting, socket should execute queued requests successfully:
     Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
      at listOnTimeout (node:internal/timers:569:17)
      at process.processTimers (node:internal/timers:512:7)

I tried to bump to the latest Sails version in package.json (not included in PR) but this seems to give the same issue as above.

Tested this out on with a sails new application and the client reconnects to the server when it stop/starts so it seems to be working fine. I am assuming that this test error has something to do with server side and within the test code or app setup within. Not sure.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment Transitive: eval, filesystem, network +40 8.74 MB eashaw
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +218 15 MB
npm/[email protected] Transitive: environment, filesystem, network, shell +8 2.4 MB darrachequesne

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant