Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Fluid tokens on Mainnet #27

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Test Fluid tokens on Mainnet #27

merged 5 commits into from
Feb 7, 2025

Conversation

joaobrunoah
Copy link
Collaborator

@joaobrunoah joaobrunoah commented Feb 6, 2025

Description

Important: We noticed some minimum and maximum limits on deposits and withdrawals of certain tokens, as described below. It allows the buffers to work, but if these limits are trespassed the transaction may revert.

  • fWETH and fWSTETH: Minimum deposit/withdraw of 2e6 wei, maximum deposit/mint of 1000 ETH
  • fGHO: Minimum deposit/withdraw of 1e9 wei

Mainnet:

  • fWETH: 0x90551c1795392094FE6D29B758EcCD233cFAa260
  • fWSTETH: 0x2411802D8BEA09be0aF8fD8D08314a63e706b29C
  • fUSDC: 0x9Fb7b4477576Fe5B32be4C1843aFB1e55F251B33
  • fUSDT: 0x5C20B550819128074FD538Edf79791733ccEdd18
  • fGHO: 0x6A29A46E21C730DcA1d8b23d637c101cec605C5B

@joaobrunoah joaobrunoah enabled auto-merge (squash) February 6, 2025 17:01
Copy link
Contributor

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just some comment suggestions. (I don't have much context on the tokens themselves, so somebody who knows how these work should review the addresses, test coverage, etc.)

test/ERC4626WrapperBase.t.sol Outdated Show resolved Hide resolved
test/ERC4626WrapperBase.t.sol Show resolved Hide resolved
test/mainnet/ERC4626MainnetFluidGho.t.sol Outdated Show resolved Hide resolved
@joaobrunoah joaobrunoah merged commit 3be38aa into main Feb 7, 2025
1 check passed
@joaobrunoah joaobrunoah deleted the fluid-tests branch February 7, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants