Consistent formatting, removal of unused dependencies#63
Open
benesjan wants to merge 2 commits intobalancer:masterfrom
Open
Consistent formatting, removal of unused dependencies#63benesjan wants to merge 2 commits intobalancer:masterfrom
benesjan wants to merge 2 commits intobalancer:masterfrom
Conversation
bonustrack
reviewed
Dec 7, 2020
Contributor
bonustrack
left a comment
bonustrack
left a comment
There was a problem hiding this comment.
Thank you for your contribution, that's looking good. I just added a suggestion. Can you fix conflict too?
.prettierrc
Outdated
| "bracketSpacing": true, | ||
| "singleQuote": true, | ||
| "semi": false, | ||
| "trailingComma": "all", |
Contributor
There was a problem hiding this comment.
Can you remove comma dangle? We don't use it in our repos
Suggested change
| "trailingComma": "all", | |
| "trailingComma": "none", |
Author
|
Hello, I removed the trailing comma and rebased my branch onto the master 😌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was inconsistently formatted and it made it hard to navigate. I added configuration for prettier package to ensure the formatting is consistent across the whole codebase. I used formatting which is as close to the original as possible. I also removed unused dependencies.