Support multiple swappers of ToB request #13
Draft
+487
−340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames `_getDigest` to `_computeDigestEmptyAttestation` for better clarity and reflects its purpose of computing the digest for empty attestations. Updates calls to reflect the name change.
EndymionJkb
reviewed
Oct 10, 2025
| bytes signature; | ||
| } | ||
|
|
||
| /*************************************************************************** |
Contributor
There was a problem hiding this comment.
Events go above errors. (Was wrong in original; I didn't catch it last time.)
Collaborator
Author
|
Converting to Draft since the implementation of ToB will change. The paths are not combined, and it needs to allow slippage since the pools may be boosted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
swapExactInandswapExactOutneed to support multiple ToB traders. These traders know exactly how much they'll pay and how much they'll receive in the transaction, so there's no minimum and maximum limits, only exact amounts.The pathsToB swap aggregates all ToB swaps and the resulting swaps need to match perfectly the sum of ToB orders.
Notice that the test coverage is not 100% anymore. That's because the user signtures are not used. However, in the next PR, a support to user swaps that come after ToB swaps will be added, so these signatures were kept in the code.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
Closes #8