new aave aprs and default yield fee #1224
Conversation
🦋 Changeset detectedLatest commit: 8d42488 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const fee = | ||
| pool.type === 'META_STABLE' | ||
| ? parseFloat(pool.dynamicData.protocolSwapFee || '0') | ||
| : pool.protocolVersion === 3 | ||
| ? parseFloat(pool.dynamicData.aggregateYieldFee || '0.1') |
There was a problem hiding this comment.
This also needs to changed in the networkconfig from 0.5 to 0.1 for v3. Also, why is it called aggregateYieldFee and not protocolYieldFee for v3 pools?
There was a problem hiding this comment.
AggregateYieldFee includes potential hook fees. We might not need a default since we always query for it on-chain. Do you agree?
There was a problem hiding this comment.
But aggregateYieldFee is still the same as protocolYieldFee?
think a default is save, I'd leave it
There was a problem hiding this comment.
I’m not sure about aggregateYieldFee vs. protocolYieldFee. I assume protocolYieldFee can be added via the protocolFeeController, but most usage will likely remain with aggregateYieldFee.
There was a problem hiding this comment.
Lets create an issue for that to revisit and merge this
No description provided.