-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix price impact for add liquidity boosted on near proportional inputs #584
base: main
Are you sure you want to change the base?
Conversation
Tests are not failing locally - any idea what's causing this unrelated test to fail on CI? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be using the wrong rpc url but this example fails on my machine
Error: addLiquidity operation will fail at SC level with user defined input.
ContractFunctionExecutionError: Missing or invalid parameters.
Double check you have provided the correct parameters.
URL: https://rpc.ankr.com/sonic_mainnet
Request body: {"method":"eth_call","params":[{"data":"0xc9b8ddb200000000000000000000000043026d483f42fb35efe03c20b251142d022783f200000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000160000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000186a000000000000000000000000000000000000000000000000000000000000186a00000000000000000000000000000000000000000000000000000000000000000"},"latest"]}
Raw Call Arguments:
data: 0xc9b8ddb200000000000000000000000043026d483f42fb35efe03c20b251142d022783f200000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000160000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000186a000000000000000000000000000000000000000000000000000000000000186a00000000000000000000000000000000000000000000000000000000000000000
Contract Call:
function: queryAddLiquidityUnbalancedToERC4626Pool(address pool, bool[] wrapUnderlying, uint256[] exactAmountsIn, address sender, bytes userData)
args: (0x43026d483f42fb35efe03c20b251142d022783f2, [false,false], ["100000","100000"], 0x0000000000000000000000000000000000000000, 0x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true - I initially branched out v1.4.3 - it was working there 🫠
I know that buildPoolStateTokenMap
should be fixed to use t.index
instead of underlying.index
but that alone isn't enough to get the example to work
I'll take another look tomorrow to investigate this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad - this won't work until the new composite router is deployed on Sonic 🤦♂️ - this fix was meant to be added as a hotfix to 1.4.3, so we'll have to put this on hold until everything else is deployed/updated
No description provided.