Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ros2 build param issues #1

Conversation

Alpaca-zip
Copy link
Contributor

Thank you for your great project!
I have found some problems in using your ROS 2 package and have made a PR about the fixes.

PR Type

  • Feature
  • Bug fix
  • Refactor
  • Documentation
  • Other

Overview

  • Fixes problems with colcon build not going through.
  • Fixes problems with access to parameters.
  • Delete unused parameter.

Detail

Test

  • I have tested this change with gazebo.

@baiyeweiguang
Copy link
Owner

Thank you for your PR! I'm not familiar with pcl-ros, so I'm not sure what role pcl-ros/point_cloud.h plays in the code.

@baiyeweiguang baiyeweiguang merged commit 237330f into baiyeweiguang:main Nov 13, 2023
@Alpaca-zip Alpaca-zip deleted the fix/ros2-build-param-issues branch November 13, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants