Add support for MessagePack mime type #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Read unmarshalls the value from byte slice and using msgpack to unmarshal | ||
| func (e entityMsgPackAccess) Read(req *Request, v interface{}) error { | ||
| data, err := ioutil.ReadAll(req.Request.Body) |
There was a problem hiding this comment.
I would use the NewDecoder function directly on the Request.Body instead.
That way you do not have to read all the bytes first. It will be more effictient that way.
bailantaotao
force-pushed
the
issue-279
branch
3 times, most recently
from
4600fee to
bfacd19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.