Skip to content

Commit

Permalink
fix dto and ordering
Browse files Browse the repository at this point in the history
  • Loading branch information
bahram1249 committed Jun 18, 2024
1 parent e3d5dab commit b43dfaa
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,4 @@ export class EntityTypeDto {
description: 'entityTypeId',
})
entityTypeId: number;

@AutoMap()
@IsOptional()
@IsString()
@ApiProperty({
required: true,
type: String,
description: 'description',
})
public description?: string;
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import { EAVEntityAttributeValue } from '@rahino/database/models/eav/eav-entity-
import { EAVAttribute } from '@rahino/database/models/eav/eav-attribute.entity';
import { EAVAttributeValue } from '@rahino/database/models/eav/eav-attribute-value';
import { InjectModel } from '@nestjs/sequelize';
import { SortOrder } from '@rahino/query-filter';

@Injectable()
export class ProductQueryBuilderService {
Expand Down Expand Up @@ -535,12 +536,12 @@ export class ProductQueryBuilderService {
.offset(filter.offset)
.order({ orderBy: 'inventoryStatusId', sortOrder: 'ASC' });
queryResultBuilder = await this.parseOrder(filter, queryResultBuilder);
// queryResultBuilder = queryResultBuilder.order([
// { model: ECInventory, as: 'inventories' },
// { model: ECVendor, as: 'vendor' },
// 'priorityOrder',
// 'asc',
// ]);
queryResultBuilder = queryResultBuilder.order([
{ model: ECInventory, as: 'inventories' },
{ model: ECInventoryPrice, as: 'firstPrice' },
'price',
'asc',
]);
return {
resultQuery: queryResultBuilder.build(),
countQuery: queryBuilder.build(),
Expand Down Expand Up @@ -579,12 +580,20 @@ export class ProductQueryBuilderService {
}
}
}
console.log(orders);
const orderItem: OrderItem = orders as OrderItem;
queryBuilder = queryBuilder.order(orderItem);
}
if (filter.orderBy.startsWith('randomize')) {
// this is very expensive
const orders = [];

let orderItemAssociation = { model: Attachment, as: 'attachments' };

orders.push(...[orderItemAssociation, 'id', 'ASC']);
const orderItemV2: OrderItem = orders as OrderItem;
queryBuilder = queryBuilder.order(Sequelize.literal('NEWID()'));
queryBuilder = queryBuilder.order(orderItemV2);
} else {
queryBuilder = queryBuilder.order({
orderBy: filter.orderBy,
Expand Down
10 changes: 10 additions & 0 deletions apps/eav/src/admin/entity-type/dto/entity-type.dto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,14 @@ export class EntityTypeDto {
description: 'metaDescription',
})
public metaDescription?: string;

@AutoMap()
@IsOptional()
@IsString()
@ApiProperty({
required: true,
type: String,
description: 'description',
})
public description?: string;
}

0 comments on commit b43dfaa

Please sign in to comment.