Skip to content

Add on before view will disappear in view presentation events handling #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add on before view will disappear in view presentation events handling #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a31cc3
Add onBeforeViewWillAppear in ViewPresentationEventsHandling
jrcmramos-bumble Dec 10, 2021
9df50e6
Merge branch 'master' into Add-onBeforeViewWillAppear-in-ViewPresenta…
jrcmramos-bumble Dec 10, 2021
643d972
Add onBeforeViewWillDisappear in ViewPresentationEventsHandling
jrcmramos-bumble Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Chatto/sources/ChatController/BaseChatViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,10 @@ public final class BaseChatViewController: UIViewController {
}

override public func viewWillDisappear(_ animated: Bool) {
self.viewEventsHandlers.forEach {
$0.onBeforeViewWillDisappear()
}

super.viewWillDisappear(animated)

self.keyboardUpdatesHandler.stopTracking()
Expand Down
1 change: 1 addition & 0 deletions Chatto/sources/ChatController/InputBar/ChatInputBarPresenterProtocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public protocol ViewPresentationEventsHandling: AnyObject {
func onViewWillAppear()
func onViewDidAppear()

func onBeforeViewWillDisappear()
func onViewWillDisappear()
func onViewDidDisappear()
func onViewDidLayoutSubviews()
Expand Down