Fix bottomConstraint calculation bug when rendering custom keyboards (such as Microsoft Swiftkey) for the first time #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(such as Microsoft Swiftkey) for the first time
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 59.07% 59.17% +0.09%
==========================================
Files 101 101
Lines 5229 5239 +10
==========================================
+ Hits 3089 3100 +11
+ Misses 2140 2139 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
any info on when this PR will be merged? |
|
will this PR be merged? |
|
您好，邮件收到
|
|
Hello, is it possible to continue with this request? |
|
您好，邮件收到
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue: #708
I did my best to limit the scope of this change and fit things into the patterns established in
KeyboardTracker.swiftIf you all have feedback or preferences for how to do this differently I am happy to oblige. This bug is a 100% repro (see video in the associated bug report) so should be easy to repro on your end if you want to go a different direction.