Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our approach for testing auth (part 2) - basicAuth #9983

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Commits on Oct 23, 2023

  1. improve stackexchange auth testing

    Change auth tests to include all shields of the base class.
    The code is formated to be used in more general cases and increases code reuseability.
    jNullj committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    764582e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e913a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Configuration menu
    Copy the full SHA
    ae1a231 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b2c2a18 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Remove dummy auth test

    We already test all existing classes, no need for a dummy
    jNullj committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    9dd597d View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Add getBadgeExampleCall to test-helpers

    Add getBadgeExampleCall to extract the first OpenAPI example then reformat it for service invoke function.
    jNullj committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    7bc3cc0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6da3af View commit details
    Browse the repository at this point in the history
  3. Fix getBadgeExampleCall Errors

    jNullj committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    31c3f94 View commit details
    Browse the repository at this point in the history
  4. Add testAuth to test-helpers

    Add the testAuth function which tests auth of a service (badge) using a provided dummy response.
    jNullj committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    18ec387 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1688e58 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    609c017 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Add all auth methods to testAuth

    Add all auth methods used to testAuth to be generic and used by all services.
    Add helper functions to make testAuth more readable
    jNullj committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    ffc7800 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Configuration menu
    Copy the full SHA
    3e5c98d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    876708f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ddd577 View commit details
    Browse the repository at this point in the history
  4. Fix basic auth user

    jNullj committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c41f60f View commit details
    Browse the repository at this point in the history
  5. Add dynamic authorizedOrigins

    jNullj committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    f4cc1af View commit details
    Browse the repository at this point in the history
  6. Add header optional argument

    jNullj committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    b471c5c View commit details
    Browse the repository at this point in the history
  7. Add obs as basicAuth example

    jNullj committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    7aadc10 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Use apiHeaderKey and bearerHeaderKey function params

    Use apiHeaderKey & bearerHeaderKey as function params rather then extracting them with regex from function strings.
    
    Those options are now part of an options object param joined with the contentType that replaces header.
    
    header was originaly added for setting content type of the reply, so it makes more sense to directly set the content type
    jNullj committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    79dc536 View commit details
    Browse the repository at this point in the history
  2. Remove old comment

    jNullj committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d1435c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Allow any pass & user key for QueryStringAuth

    Before this commit the QueryStringAuth would only work for the key of stackexchange.
    This commit makes the testAuth function generic and allows passing user and pass keys.
    jNullj committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    a53f716 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14d0789 View commit details
    Browse the repository at this point in the history
  3. Fix wrong header for jwt login

    Might set wrong header for jwt login request.
    This commit fixes that.
    jNullj committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d22de8a View commit details
    Browse the repository at this point in the history
  4. Support multiple authOrigins in testAuth

    Some services might have more then one authOrigin.
    This commit makes sure we test for redundent authOrigins as well as support requests to them if needed.
    jNullj committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    50f4144 View commit details
    Browse the repository at this point in the history
  5. Add docker-automated auth test

    jNullj committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    2d310bd View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Fix JwtAuth testing by introducing mandatory jwtLoginEndpoint

    Prior to this change, JwtAuth testing would lead to erros due to the absence of a specified login endpoint,
    Nock would be dumplicated for both login and non login hosts and indicate a missing request.
    
    This commit enforces the requirement for a new jwtLoginEndpoint argument when testing JwtAuth.
    The argument seperates the endpoint nock scope from the behavior of the request nock.
    jNullj committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    1b79b4c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    419bd01 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    a2b838c View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    2590482 View commit details
    Browse the repository at this point in the history
  2. Add exampleOverride to testAuth

    Introduce `exampleOverride` to test authentication scenarios.
    Allows providing custom examples for testAuth via an object.
    Simulates service requests that trigger desiered condition paths in tests.
    jNullj committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4d57607 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Add authOverride to testAuth

    Some classes can change the auth based on badge inputs.
    This parameter allows the flexability of overriding the default auth for testing those cases.
    jNullj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    f156762 View commit details
    Browse the repository at this point in the history
  2. Add configOverride to testAuth

    Some tests might require non default config for cases where these are set.
    This allows creating tests for those cases.
    jNullj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    cd6c65b View commit details
    Browse the repository at this point in the history
  3. Fix example params by split into path and query

    Splits testAuth example params into path and query params.
    Introduce paramType to getBadgeExampleCall
    jNullj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    cf34fae View commit details
    Browse the repository at this point in the history
  4. Refactor BitbucketPullRequest for testAuth

    Refactor to add auth static properties.
    for better integration with testAuth.
    
    Refactor bitbucketpullrequest for testAuth
    jNullj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    8adaf3d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    988290d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b9d51d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    b23e3d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Configuration menu
    Copy the full SHA
    84bee80 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Configuration menu
    Copy the full SHA
    1c15782 View commit details
    Browse the repository at this point in the history
  2. Improve error handling in getServiceClassAuthOrigin

    Enhance reliability by throwing a TypeError when a service key definition is missing.
    It's common for a key to be missing and might require the developer that writes tests to provide a fake on that fits the examples used.
    
    Key changes:
    - Added a check for missing service key definitions in getServiceClassAuthOrigin.
    - Throws a TypeError with a clear message if the key is not found.
    - Guides devs to use an override if needed which is often.
    jNullj committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    a713669 View commit details
    Browse the repository at this point in the history
  3. Fix edge case in testAuth for user only auth

    Addresses a scenario where generateFakeConfig/testAuth would fail for classes using auth.userKey without auth.passKey.
    Ensures proper handling of user-specific authentication even if a password key is not present.
    Throws a TypeError only when both fakeKey and fakeUser are missing.
    Better fit for AuthHelper behivor.
    jNullj committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    99a01e1 View commit details
    Browse the repository at this point in the history
  4. Add option to not import openApi example in testAuth

    Added for services without openApi examples.
    Dev can use example override to add example inputs in those cases.
    jNullj committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    74554d7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8b8bf19 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    a2b5331 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87c68e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Configuration menu
    Copy the full SHA
    8c38355 View commit details
    Browse the repository at this point in the history
  2. Add support for multiple requests in testAuth function

    Some services might have more then one request to auth with the server for the same shield.
    This commit adds support for those requests in testAuth using the new multipleRequests option.
    jNullj committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    57163eb View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Configuration menu
    Copy the full SHA
    5dc774a View commit details
    Browse the repository at this point in the history
  2. Fix async mocha tests

    Missing return for async mocha tests caused the tests to run async and throw errors of one test in another.
    This commit makes sure all testAuth tests return a promise to mocha for it to await.
    jNullj committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1b425aa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    94a479a View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Configuration menu
    Copy the full SHA
    ee75674 View commit details
    Browse the repository at this point in the history
  2. Remove ignoreOpenApiExample option in testAuth function

    The `ignoreOpenApiExample` option in the `testAuth` function is no longer needed and has been removed. This option was used to ignore OpenAPI examples for classes without OpenAPI, but it is no longer necessary as the function now handles this case correctly.
    BaseService defines by dafault empty object for openApi so if nothing is set we expect empty obj.
    Warn devs about missing openApi as openApi is standard for services now.
    jNullj committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    263aba7 View commit details
    Browse the repository at this point in the history
  3. handle extraction of openApi boolean examples

    Improve authTest by handeling boolean example extractions.
    Remove example override not needed after this change.
    jNullj committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    669d913 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Use static headers in base service classes and remove contentType opt…

    …ion from testAuth
    
    Refactor the base service classes (BaseGraphqlService, BaseJsonService, BaseSvgScrapingService, BaseTomlService, BaseXmlService, BaseYamlService) to use static headers for access from other function to header types.
    Remove testAuth contentType option and use the new headers veriable to extract headers insted.
    jNullj committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    625042e View commit details
    Browse the repository at this point in the history
  2. Remove contentType option tests using testAuth

    This option is removed
    jNullj committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    059b8ca View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    9e58dde View commit details
    Browse the repository at this point in the history
  2. Update jenkinsCoverage response

    Example changed at 62ed7c3
    The new example schema differ from old one
    This caused test to fail
    Update example response to fit new schema
    jNullj committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    73b3e14 View commit details
    Browse the repository at this point in the history
  3. remove BitbucketPullReuqest tests

    remove for adding these changes in a later PR.
    this test adds the authOverride we try to get rid of.
    This blocks testAuth development and is planned for a later time.
    jNullj committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1fdf395 View commit details
    Browse the repository at this point in the history