Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESLint 9 #10762

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .eslintignore

This file was deleted.

189 changes: 0 additions & 189 deletions .eslintrc.yml

This file was deleted.

2 changes: 1 addition & 1 deletion core/base-service/coalesce-badge.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ export default function coalesceBadge(
label: overrideLabel,
logo: overrideLogo,
logoColor: overrideLogoColor,
logoSize: overrideLogoSize,
link: overrideLink,
colorB: legacyOverrideColor,
colorA: legacyOverrideLabelColor,
} = overrides
let {
logoWidth: overrideLogoWidth,
logoSize: overrideLogoSize,
color: overrideColor,
labelColor: overrideLabelColor,
} = overrides
Expand Down
2 changes: 0 additions & 2 deletions core/base-service/legacy-request-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ function handleRequest(cacheHeaderConfig, handlerOptions) {
const result = handlerOptions.handler(
filteredQueryParams,
match,
// eslint-disable-next-line mocha/prefer-arrow-callback
function sendBadge(format, badgeData) {
if (serverUnresponsive) {
return
Expand All @@ -128,7 +127,6 @@ function handleRequest(cacheHeaderConfig, handlerOptions) {
makeSend(format, ask.res, end)(svg)
},
)
// eslint-disable-next-line promise/prefer-await-to-then
if (result && result.catch) {
// eslint-disable-next-line promise/prefer-await-to-then
result.catch(err => {
Expand Down
2 changes: 1 addition & 1 deletion core/service-test-runner/service-tester.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class ServiceTester {
.before(() => {
this.beforeEach()
})
// eslint-disable-next-line mocha/prefer-arrow-callback, promise/prefer-await-to-then
// eslint-disable-next-line promise/prefer-await-to-then
.finally(function () {
// `this` is the IcedFrisby instance.
let responseBody
Expand Down
Loading
Loading