Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate [JenkinsPluginInstalls] per version #10747

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Dec 15, 2024

The corresponding tests started failing over a month ago, the API is consistently returning an empty installationsPerVersion field. I tried following up on an issue about this, but the response wasn't terribly helpful. I suggest we deprecate the version flavour of the badge, the total installs part of the API still seems to be returning sensible results for now.

@PyvesB PyvesB added the service-badge New or updated service badge label Dec 15, 2024
Copy link
Contributor

github-actions bot commented Dec 15, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 6001491

@chris48s
Copy link
Member

Where did you raise an issue?

From last time we had an issue with this API it seems https://github.com/jenkins-infra/helpdesk/issues is the place they track issues for this, using the stats.jenkins.io label

@PyvesB
Copy link
Member Author

PyvesB commented Dec 15, 2024

The issue I had found is here: jenkins-infra/stats.jenkins.io#215

From the get go the first few messages in November feel off to me, I kinda got burnt as well, and things have since then escalated to a quarrel between two of the Jenkins maintainers. They're apparently continuing the argument in another issue on https://github.com/jenkins-infra/helpdesk/issues, it's really all a bit ridiculous at this point. I'm not getting involved any further, I don't think it's a good use of my Shields.io time and energy.

@krisstern
Copy link

For the record we have a separate issue to track the original issue at jenkins-infra/stats.jenkins.io#265. @PyvesB has been asked to follow some suggestions but he would not listen.

@krisstern
Copy link

Where did you raise an issue?

From last time we had an issue with this API it seems https://github.com/jenkins-infra/helpdesk/issues is the place they track issues for this, using the stats.jenkins.io label

That's exactly right, the relevant helpdesk issue can be readily found at jenkins-infra/helpdesk#4386.

@krisstern
Copy link

Also @PyvesB did not raise a new issue as suggested, but insisted on commenting on an already closed issue in our stats.jenkins.io repo that is not 100% related. I believe the single source of truth should and is always the helpdesk issue cited in #10747 (comment), that's why I did not want to repeat myself or relay anything faulty in the already closed issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants