You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, while doing this I realised that shields don't use **bibytes but divide by 1000 instead. I just followed what the rest of the badges do but are there any plans of adding support for this? Since there's now an inconsistency between the badge's number and the one on crates.io/docker/github repo size
Also, while doing this I realised that shields don't use **bibytes but divide by 1000 instead. I just followed what the rest of the badges do but are there any plans of adding support for this? Since there's now an inconsistency between the badge's number and the one on crates.io/docker/github repo size
Will point back to #9703 (comment) as I believe our position is still the same.
Our main goal is consistency within the Shields ecosystem, but we can certainly consider offering support for these types of variances when it makes sense
Also, while doing this I realised that shields don't use **bibytes but divide by 1000 instead. I just followed what the rest of the badges do but are there any plans of adding support for this? Since there's now an inconsistency between the badge's number and the one on crates.io/docker/github repo size
Will point back to #9703 (comment) as I believe our position is still the same.
Thanks for digging that comment out. I knew it had come up before. Lets keep the scope of this PR to just merging this in its current form. I am going to write up another issue about this topic. I do think it is worth doing though.
service-badgeAccepted and actionable changes, features, and bugs
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chris48s
added
the
service-badge
Proposed in #6011
Didn't make the issue but last message was 2021 so I figured it was safe and I needed this.
Routes:
Crates.io Size: /crates/size/:crate
Crates.io Size (version): /crates/size/:crate/:version