Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use metric() for [discord] and [revolt] badges #10406

Merged
merged 1 commit into from
Jul 26, 2024
Merged

use metric() for [discord] and [revolt] badges #10406

merged 1 commit into from
Jul 26, 2024

Conversation

chris48s
Copy link
Member

Refs #10249 (comment)

These badges display exact values, but they should really use metric()

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 97104e4

PyvesB
PyvesB approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏻

@chris48s chris48s added this pull request to the merge queue Jul 26, 2024
Merged via the queue into badges:master with commit be542e1 Jul 26, 2024
24 checks passed
@chris48s chris48s deleted the chat-metrics branch July 26, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris48s @PyvesB