Skip to content

chore(graphql-voyager): migrate workspace to Jest 30 - #10962

Open
LouisDeconinck wants to merge 2 commits into
backstage:mainfrom
LouisDeconinck:graphql-voyager-jest-30
Open

LouisDeconinck wants to merge 2 commits into
backstage:mainfrom
LouisDeconinck:graphql-voyager-jest-30

Conversation

@LouisDeconinck

Copy link
Copy Markdown
Contributor

Hey, I just made a Pull Request!

Migrates the graphql-voyager workspace to Jest 30 as part of #7868.

Validation completed locally:

  • yarn tsc:full
  • Backstage test CLI 0.36.5
  • 6/6 existing tests passing (3 suites)
  • Prettier check

No test changes were required. Added @types/node@22.20.1 and @types/webpack-env@1.18.8 resolutions to fix @types/node lib type errors under tsc:full (same approach as the merged gcalendar migration).

Disclosure: this PR was largely produced with AI assistance; the changes have been reviewed and verified locally.

✔️ Checklist

  • A changeset describing the change and affected packages.
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message.

Signed-off-by: Louis Deconinck <louis.dck@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved issues were identified, and all approval-readiness assessments approve the changes.

Pull request overview

Migrates the graphql-voyager workspace test tooling to Jest 30 with compatible type dependencies.

Changes:

  • Adds Jest 30, JSDOM 27, and related typings.
  • Pins Node and webpack environment types.
  • Refreshes the workspace lockfile.
File summaries
File Description
workspaces/graphql-voyager/package.json Adds Jest 30 dependencies and type resolutions.
workspaces/graphql-voyager/yarn.lock Locks the updated Jest and JSDOM dependency graph.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Signed-off-by: Louis Deconinck <louis.dck@gmail.com>
Copilot AI review requested due to automatic review settings September 12, 2026 08:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments; validation and existing tests pass.

Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants