feat : 결과 저장하는 로직 추가 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Test code-coverage reports
|
|
테스트 코드좀 추가해야겠네요 ㅋㅋ 18%로 라니,,😂 |
ghkdqhrbals
reviewed
Mar 30, 2024
There was a problem hiding this comment.
이 부분에서 Transaction 단위로 이루어졌으면 좋겠습니다.
만약 saveTps 후 saveMttfb 가 오류날 시, 기존 저장된 Tps 는 롤백이 불가능 할 것 같아요!
📝 Test code-coverage reports
|
📝 Test code-coverage reports
|
📝 Test code-coverage reports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이벤트 처리후 데이터 저장하는 부분 추가했습니다!!
빈 값으로 넘겼더니 json으로 변환 처리 하는 부분이 여러군대 있어서 최초 저장시 {} 으로 저장 되도록 수정했습니다.
subscribe 에서 처리 하도록 구현 하였습니다.