Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate asynctest to stdlib's AsyncMock #39

Closed
fabaff opened this issue Sep 10, 2020 · 1 comment · Fixed by #40
Closed

Migrate asynctest to stdlib's AsyncMock #39

fabaff opened this issue Sep 10, 2020 · 1 comment · Fixed by #40
Labels
bug Bugs or issues which will cause a problem for users

Comments

@fabaff
Copy link
Contributor

fabaff commented Sep 10, 2020

Describe the bug
Asynctest doesn't work with Python 3.8 and above.

Asynctest upstream is aware of this breakage and recommends using the built-in AsyncMock instead.

See also Martiusweb/asynctest#144 and Martiusweb/asynctest#126
@issuelabeler issuelabeler bot added the bug Bugs or issues which will cause a problem for users label Sep 10, 2020
@bachya
Copy link
Owner

bachya commented Sep 10, 2020

Appreciate the heads up. How do I fix those so that I can still run 3.6/3.7 tests?

@bachya bachya mentioned this issue Sep 10, 2020
Merged
3 tasks
@bachya bachya mentioned this issue Sep 10, 2020
Merged
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle asynctest not working in Python 3.8 bachya/pyopenuv
2 participants
@bachya @fabaff