Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle asynctest not working in Python 3.8 #40

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Handle asynctest not working in Python 3.8 #40

merged 1 commit into from
Sep 10, 2020

Conversation

bachya
Copy link
Owner

@bachya bachya commented Sep 10, 2020

Describe what the PR does:

This PR fixes the fact that asynctest no longer works in Python 3.8. The PR still ensures that it can be used for Python 3.6 and 3.7.

Does this fix a specific issue?

Fixes #39

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Sep 10, 2020
@bachya bachya self-assigned this Sep 10, 2020
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 10, 2020

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.00 0.00 0.00
Method Length 50.81 50.81 0.00
Quality 8.76 8.76 0.00
Other metrics Before After Change
Lines 162 162 0
Changed files Quality Before Quality After Quality Change
tests/test_client.py 8.76 8.76 0.00

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codeclimate
Copy link

codeclimate bot commented Sep 10, 2020

Code Climate has analyzed commit 65e0c4a and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #40 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           54        54           
=========================================
  Hits            54        54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714af81...65e0c4a. Read the comment docs.

@bachya bachya merged commit 50829e4 into dev Sep 10, 2020
@bachya bachya deleted the asynctest branch September 10, 2020 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate asynctest to stdlib's AsyncMock
1 participant