feat: return btc price in stats endpoint #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-babylonlabs
approved these changes
Dec 3, 2024
internal/services/stats.go
Outdated
| price, err := s.GetLatestBtcPriceUsd(ctx) | ||
| if err != nil { | ||
| log.Ctx(ctx).Error().Err(err).Msg("error while fetching latest btc price") | ||
| return nil, types.NewInternalServiceError(err) |
There was a problem hiding this comment.
Let's not fail the whole request due to this. We should emit a metric and have alert based on this, but silently fail by fall back to empty value for the additional field we added in the stats response.
FE will handle it gracefully.
jrwbabylonlab
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #166
This pr
When fetched first time
After TTL (currently 3 seconds in local config)
in /v1/stats