Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve #9 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solve #9 #10

wants to merge 1 commit into from

Conversation

hax
Copy link
Contributor

@hax hax commented Jun 17, 2016

No description provided.

@hzoo
Copy link
Member

hzoo commented Jun 17, 2016

Just add the https://github.com/59naga/babel-plugin-add-module-exports plugin to package.json/the file instead

@hax
Copy link
Contributor Author

hax commented Jun 17, 2016

@hzoo We only need transform lib/index.js, so add this plugin to config which will apply to src/* seems too heavy?

@hzoo
Copy link
Member

hzoo commented Jun 17, 2016

What do you mean by the plugin being too heavy? It's the same as #8 - need to add to the devDependencies + the babelrc

Oh because there's only 1 file for the plugin; some plugins can have multiple?

@hax
Copy link
Contributor Author

hax commented Jun 17, 2016

Yes. Maybe we can change build command to babel src -d lib && babel lib/index.js --plugins add-module-exports --out-file lib/index.js?

@jamiebuilds
Copy link
Contributor

I think we should just add that plugin all the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants