Update core-js
#223
Merged
Update core-js
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zloirock
commented
Oct 31, 2024
| ]), | ||
| emplace: define("instance/emplace", [ | ||
| "esnext.map.emplace", | ||
| "esnext.weak-map.emplace", |
There was a problem hiding this comment.
With the current approach, it should be injected on constructors call, and that's already happening. Here are missed dependencies and in this way anyway it could cause a error. However, in case of pure mode + targets, injection on constructor call could fail because of #166.
zloirock
commented
Nov 1, 2024
| ]), | ||
| endsWith: define("instance/ends-with", ["es.string.ends-with"]), | ||
| entries: define("instance/entries", ArrayNatureIteratorsWithTag), | ||
| every: define("instance/every", [ | ||
| "es.array.every", | ||
| "esnext.async-iterator.every", |
There was a problem hiding this comment.
Because lack of dependencies, it could cause a error, so this and similar cases commented. They are covered by AsyncIteratorProblemMethods.
liuxingbaoyu
approved these changes
Nov 1, 2024
JLHwung
approved these changes
Nov 1, 2024
|
@nicolo-ribaudo could you publish a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.