Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extra optional argument headers #9

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Adds extra optional argument headers #9

merged 4 commits into from
Nov 1, 2023

Conversation

rafaeldelboni
Copy link
Contributor

Closes: #8
Related to: #7

@rafaeldelboni
Copy link
Contributor Author

rafaeldelboni commented Oct 25, 2023

I don't know if you want me to bump version.edn file as well and sorry for any ugly code :)

@borkdude
Copy link
Collaborator

I don't think the test folder requires another .clj-kondo directory

@borkdude
Copy link
Collaborator

One problem with the string + split way of doing things on the CLI is that headers can start with colons and these would be parsed as the next option. I think coercing the headers as :edn might make more sense in this case?

@rafaeldelboni
Copy link
Contributor Author

Sure, makes sense

@rafaeldelboni
Copy link
Contributor Author

@borkdude could you check if my change makes sense?

@borkdude
Copy link
Collaborator

borkdude commented Nov 1, 2023

Looks good to me!

@borkdude borkdude merged commit 6964d9e into babashka:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to pass extra body headers
2 participants