Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add separator when base-path is not actual root #118

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

eval
Copy link
Contributor

@eval eval commented Oct 10, 2023

Fixes #117
Please answer the following questions and leave the below in as part of your PR.

Writing to root-folder in a test seems not a great idea, and (match "/" "glob:some/path/some-file" {:recursive true}) would be time consuming... Other ideas?

  • I have updated the CHANGELOG.md file with a description of the addressed issue.

@borkdude
Copy link
Contributor

Thanks! Can you explain the fix? It's been a while since I worked on this code... 😓

@borkdude
Copy link
Contributor

oh I think I got it already, if you provide a root path that ends with the file separator, there is no need to add it.

@borkdude borkdude merged commit a5744e2 into babashka:master Oct 10, 2023
6 checks passed
@borkdude
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs/match won't find things in root-folder
2 participants