-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fish: performance improvments, add piping, fixes #218
Open
gazorby
wants to merge
15
commits into
babarot:master
Choose a base branch
from
gazorby:perf/in-memory-logs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/fish
Catch all for changes in fish files
missing/bash
Denotes a PR that needs to include changes against missing area
labels
Sep 4, 2023
gazorby
changed the title
Performance improvments, add piping
fish: performance improvments, add piping
Sep 4, 2023
gazorby
changed the title
fish: performance improvments, add piping
fish: performance improvments, add piping, fixes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/fish
Catch all for changes in fish files
missing/bash
Denotes a PR that needs to include changes against missing area
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
type -q
calls by storing awk/filter commands in variablesWHY
Bring feature parity with zsh (piping) and improve overall latency by storing directories in memory instead of a file and freeing up execution time by moving some checks at shell init.
The existing
~/.enhancd/enhancd.log
file will be read to fill the variable if it's empty to make the migration seamless.The rewrite in
_enhancd_filter_interactive.fish
is mainly due to avoid buffering so we can takeadvantage of finders able to stream stdin, like fzf.
Simplistic benchmarks
Here are some benchmarks with the filter disabled for each version.
Log file / variable size: 345
Fish version: 3.6.1
Platform: WSL 1.3.15.0
10 runs
Command:
Results:
Latest enhancd (230695f)
perf/in-memory-logs
500 runs
Command:
Results:
Latest enhancd (230695f)
perf/in-memory-logs