Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global filter for idea labels #429

Merged
merged 44 commits into from
Oct 14, 2024
Merged

add global filter for idea labels #429

merged 44 commits into from
Oct 14, 2024

Conversation

JannikStreek
Copy link
Member

@JannikStreek JannikStreek commented Oct 7, 2024 •
edited
Loading

Further Notes

ordering

Todos

  •  Refactor filter / broadcasting
  • Remove white underlining of filters (links)
  • Show indication when a label filter is activated, e.g. border or something
  • Add button to remove all filters
  • Only enable filter for admins
  • When filters are removed, update the position_order of the remaining cards, so that they appear after the just edited cards. Otherwise they are mixed together.
  • Adding new ideas with active filter should add these ideas automatically to these set filters. Otherwise the ideas are not shown which is confusing.
  • Tests

closes #298

PragTob
PragTob reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small intermittent thoughts

lib/mindwendel/lanes.ex Outdated Show resolved Hide resolved
lib/mindwendel/lanes.ex Outdated Show resolved Hide resolved
lib/mindwendel/lanes.ex Outdated Show resolved Hide resolved
@JannikStreek
refactor
98f7cba
@JannikStreek
refactor
1f0c5cd
@JannikStreek
refactor
7bc5045
@JannikStreek
use lane context instead of brainstorming context in show brainstormi…
15425bf 
…ng as there should one be one way of aquiring the data. In addition, the lane info is often not used as the query is used for different purposes
@JannikStreek
fix tests
7424cf5
@JannikStreek
add link
9f1f865
@JannikStreek
add filter logic to view
e3f61fc
@JannikStreek
missed migration
0bebb50
PragTob
PragTob reviewed Oct 8, 2024
View reviewed changes
lib/mindwendel/lanes.ex Outdated Show resolved Hide resolved
JannikStreek
JannikStreek commented Oct 9, 2024
View reviewed changes
lib/mindwendel/ideas.ex Outdated Show resolved Hide resolved
@JannikStreek JannikStreek changed the title WIP: started adding filter for lane ideas add filter for idea labels Oct 14, 2024
@JannikStreek JannikStreek changed the title add filter for idea labels add global filter for idea labels Oct 14, 2024
@JannikStreek JannikStreek enabled auto-merge (squash) October 14, 2024 08:28
@JannikStreek JannikStreek merged commit 12d8b84 into master Oct 14, 2024
8 checks passed
@JannikStreek JannikStreek deleted the add-filter-by-label branch October 14, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragTob PragTob PragTob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Filter by label
2 participants
@JannikStreek @PragTob