Build(deps): Bump phoenix_html from 3.3.4 to 4.1.1

[dependabot]

Necessary Changes

Needed to replace the form

Visual changes

Thanks to the form component being happy to tell you it's valid/non valid there is an additional check mark now. Since it's also there when it's actually invalid we probably want to remove it... probably by creating an even separate component/option to hide the valid check mark.

Before:

Now:

Other changes

Added a required attribute which is the only real validation so that already happens client side, as error handling was also broken before and this seems nicer :)

Todos

• Test: I could comment out the whole form and all tests passed, which doesn't make me feel easy

Original dependabot fun

Bumps phoenix_html from 3.3.4 to 4.1.1.

Changelog

Sourced from phoenix_html's changelog.

v4.1.1 (2024-03-01)

• Fix dependency resolution error

v4.1.0 (2024-02-29)

• Enhancements
  • Introduce form :action and consider input as changed if action changes to support better change tracking

v4.0.0 (2023-12-19)

This version removes deprecated functionality and moved all HTML helpers to a separate library. HTML Helpers are no longer used in new apps from Phoenix v1.7, instead it relies on function components from Phoenix.LiveView. Older applications who wish to maintain compatibility, add {:phoenix_html_helpers, "~> 1.0"} to your mix.exs and then replace use Phoenix.HTML in your applications by:

import Phoenix.HTML
import Phoenix.HTML.Form
use PhoenixHTMLHelpers

v3.3.3 (2023-10-09)

• Enhancements
  • Allow string fields on input_changed?

v3.3.2 (2023-08-10)

• Enhancements

  • Address deprecations in Elixir v1.16+

• Deprecations

  • Deprecate inputs_for/2 and inputs_for/3 (without anonymous functions)

v3.3.1 (2023-02-27)

• Bug fix
  • Set display to none on generated forms
  • Warn for maps with atom keys

v3.3.0 (2023-02-10)

• Enhancements

  • Support deeply nested class lists
  • Implement Phoenix.HTML.Safe for URI
  • Implement Phoenix.HTML.FormData for Map

• Bug fix

  • Generate unique IDs for checkboxes based on the value
  • Use artificial button click instead of form.submit in JavaScript to trigger all relevant events
  • Fix a bug where nil/false/true attributes in aria/data/phx would emit empty or literal values, such as "true" and "false". This release aligns them with all other attributes so both nil and false emit nothing. true emits the attribute with no value.

• Deprecations

... (truncated)

Commits

• 2b222db Release 4.1.1
• 30eee8f Formatter
• 640060c Release 4.1.0
• 85c33de Release 4.1.0
• adf1c38 Merge pull request #439 from phoenixframework/cm-form-action-changed
• 323a65a Update lib/phoenix_html/form.ex
• 3b960be Make josé happy
• 304dfc3 Bump docs
• f7bd1f6 No need to track id
• 5f6e91a Consider form action and method changing as changed
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[dependabot]

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

[dependabot]

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

[PragTob]

[JannikStreek]

The visual check mark is now present basically in all inputs since we switched to components, e.g. in the admin page or idea forms (creating a new idea). I would prefer to have it initially without the green check mark, especially as it's sometimes wrong and you have to provide data before it's valid (so the green check is misleading). But its also not critical, so we can make a separate issue to of it ?

[PragTob]

Separate issue sounds good. It seems like it's always initially there to be more "positive" I guess as it always defaults the errors to empty if the input wasn't used before:

  def input(%{field: %Phoenix.HTML.FormField{} = field} = assigns) do
    errors = if Phoenix.Component.used_input?(field), do: field.errors, else: []

    # the other stuff
  end

I guess we could easily instead pass on a value like "unused" for which we'd neither display the is-valid or is-error classes

[PragTob]

Follow up issue: #407