Repository navigation
[BUGFIX] Use the rendered width for srcset descriptors - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variants were labelled with the requested width, so a candidate the processor could not deliver at that size still claimed it. With
processor_allowUpscalingoff, an 800px original asked for five variants produced five candidates pointing at the same file under five different descriptors, and the browser dropped all but one of them as repeated width descriptors.The descriptor now comes from the processed image, and a width that is already in the srcset is skipped. Where the requested width can be delivered, which is the normal case, the output is unchanged.
The functional test runs with upscaling disabled and uses its own fixture rather than
storage_with_file.csv, because it needs asys_file_metadatarow: a processed file that falls back to the original carries no dimensions of its own and reads them from the original's metadata.Fixes: #103