Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds collapse to child columns #424

Closed
wants to merge 0 commits into from
Closed

Adds collapse to child columns #424

wants to merge 0 commits into from

Conversation

garbast
Copy link

@garbast garbast commented Jun 29, 2023

With this change it is possible to collapse each child column
individually and adds configuration to container definition
with which it is possible to define, which column should be
collapsed by default.

Resolves: #123

@larsgoo
Copy link

larsgoo commented Aug 16, 2023

Thanks for your work @garbast ! We are using this in an in-development project and so far I've only gotten positive feedback, everything seems to work as intended. Hope this finds its way into a future container release - Working with nested accordions does no longer give our editors a headache :D

@garbast
Copy link
Author

garbast commented Oct 10, 2023

Ping. Can we get any traction on this pull request?

@achimfritz
Copy link
Contributor

i would suggest to not include this Feature in EXT:container, but provide a new Extension (e.g. EXT:collapsible_container) which can be used if needed by Integrators easily.

This is my Suggest:

Provide JS, HTML and CSS Code in this Extension

Integrators can simply modify Grid Layout/Templates/Partial Paths when register container (s. https://github.com/b13/container/blob/master/README.md#methods-of-the-containerconfiguration-object (setGridTemplate, setGridPartialPaths, addGridPartialPath, setGridLayoutPaths)) and use "collapsible_container" Extension.

The Code-Base of EXT:container should be keeped Small, and focus more on Stablity than on Features. Features or Custom Requirements can be provided by Site Extension or by other Extensions (i did already anything crazy stuff you cannot imaging)

Thanks for your work, and please put it into an own Extension (ask me if anything is missing)

@evoWeb
Copy link

evoWeb commented Dec 9, 2023

The problem is, that it isn't done by just adding some frontend files. The ContainerGridColumn and the ContainerPreviewRenderer need to be modified too.

ContainerGridColumn needs to be modified to be able to define if container are collapsed by default.

ContainerPreviewRenderer need to be modified to respect users previous choice of collapsing and un-collapsing a container.

Cant we agree, that this are modifications worth merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: collapsing content
4 participants