Skip to content

Conversation

mamueluth
Copy link
Member

changes for command side, publishing missing

add time and publishing of when command is received

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@mergify
Copy link

mergify bot commented Jun 14, 2023

This pull request is in conflict. Could you fix it @mamueluth?

@mamueluth mamueluth force-pushed the distributed_control_aio_header_time branch 2 times, most recently from 0023e3e to b2f8f91 Compare June 14, 2023 13:10
@mamueluth mamueluth force-pushed the distributed_control_aio branch from 3ad3fd3 to a9a5998 Compare June 14, 2023 13:16
@mamueluth mamueluth force-pushed the distributed_control_aio_header_time branch from b2f8f91 to 60e0a9a Compare June 14, 2023 13:16
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Apr 11, 2025
Copy link

mergify bot commented Apr 11, 2025

@mamueluth, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to distributed_control_aio, but it must be in master
to have these changes reflected into new distributions.

@github-actions github-actions bot removed the stale label Apr 14, 2025
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant