Skip to content

Conversation

VitezGabriela
Copy link

Goal:

Update the Controller Manager to handle errors when the ResourceManager fails to initialize due to an invalid URDF or faulty hardware plugin.

Behavior:

  • Catch exceptions caused by parsing invalid URDFs during initialization
  • Log error messages
  • Reset the resource_manager_ pointer to a minimal, safe state.
  • Continue waiting for a valid robot_description to be published

Observations:

The Controller Manager now no longer crashes on invalid URDFs. Instead, it safely recovers by initializing the resource_manager_ pointer to a minimal state, allowing the controller manager to continue operating and respond to future valid robot descriptions.

Testing:
Unit tests were created with multiple invalid URDF scenarios. All tests passed successfully. Testing can be done by executing:
./build/controller_manager/test_controller_manager_with_resource_manager

Copy link

mergify bot commented Oct 14, 2025

This pull request is in conflict. Could you fix it @VitezGabriela?

@VitezGabriela VitezGabriela changed the base branch from master to jazzy October 16, 2025 07:33
Copy link

mergify bot commented Oct 16, 2025

@VitezGabriela, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to jazzy, but it must be in master
to have these changes reflected into new distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant