Skip to content

Final variant support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

Final variant support #21

wants to merge 34 commits into from

Conversation

mamueluth
Copy link
Member

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

mamueluth and others added 30 commits July 29, 2024 11:26
@mamueluth
move creation of stateinterfaces to systeminterface
ca09872
@mamueluth
store description in state_interface and provide functions for
c936484 
setting/gettting
@mamueluth
return correct name for InterfaceDescription
b7f8a24
@mamueluth
move parsing of interface description to component parser
d7fe503
@mamueluth
adjusted actuator- and sensor_interface as well
fc663d4
@mamueluth
add first tests
5b7b72c
@mamueluth
adjust sensor_interface getting/setting and add tests
616a951
@mamueluth
add more tests
3f061b5
@mamueluth
first steps towards variants and storing of value in handle, missing:
5784ade 
* variant
* adjusting of resource manager
@mamueluth
add variant support
c42d23c
@mamueluth
adjusted resource manager to work with shared_ptr adapt actuator,sensor
1be5cc4 
and system
@mamueluth
cleanup
bfb59e4
@mamueluth
fix failing tests
7946a77
@mamueluth
change rest of component_interface test and mark what should be removed
17d43d3
@mamueluth
code review suggestions and:
5f0bf43 
* components check for export of interfaces
* change intefaces to allow custom export and test
@mamueluth
undo prefix_ -> prefix (HWInfo) and Command-/StateIntefaceSharedPtr
ac376f9
@mamueluth
merge parser functions
44af40d
@mamueluth
export_interfaces_2() virtual for custom interface export
bd064f0
@mamueluth
use unordered map and adjust tests
ca89202
@mamueluth
make states and commands of component interfaces private
6795a96
@mamueluth
add migration guide for
5ad4044
@mamueluth
update writing a hardware component
4addfe3
@christophfroehlich @mamueluth
Fix RST syntax and some typos (#18)
9d78bb7 
* Fix rst syntax and some typos

* Fix rst syntax and small typos

* Fix clang issue
@mamueluth
add changes for chainable controllers (epxport of rerference interfaces)
66d204e
@mamueluth
rename export_state/command_interface_2 to export_state/commad_interf…
444a36c 
…ace_descriptions
@mamueluth
adapt to new changes and remove some rebase artefacts
e90413c
@mamueluth
fix test failures
5276747
@mamueluth
add interface for warning, error and report
267df75 
 * ddd basic test for error codes setting
 * docs for error and warning signals
@mamueluth
full variant support :
6303e83 
 * add parsing of handle type for initialization of variant and adjust most tests
 * rename unclear variables
 * add changes for chainable controllers (epxport of rerference interfaces)
@mamueluth
remove old functionallity and continue adapting tests
395c50c
@mamueluth
continue adapting tests and small updates on handle and interfaces:
ae2ba28 
* add function for checking if handle holds value
@mergify Mergify
Copy link

mergify bot commented Aug 26, 2024

This pull request is in conflict. Could you fix it @mamueluth?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Apr 11, 2025
@mergify Mergify
Copy link

mergify bot commented Apr 11, 2025

This pull request is in conflict. Could you fix it @mamueluth?

@github-actions github-actions bot removed the stale label Apr 14, 2025
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mamueluth @christophfroehlich