[WIP] Distributed control poc #1
Conversation
| controller_manager_msgs::msg::PublisherDescription create_publisher_description_msg() const; | ||
|
|
||
| private: | ||
| void publish_value_on_timer(); |
There was a problem hiding this comment.
We should publish on events an not on timer. For example when one of read, write or update methods is called.
| namespace distributed_control | ||
| { | ||
|
|
||
| class SubControllerManagerWrapper final |
|
|
||
| virtual std::string get_underscore_separated_name() const override | ||
| { | ||
| // remove first "/" from namespace and replace all follow occurrences with "_" |
There was a problem hiding this comment.
Probably needed for node names. Why not use one node name per CM/RM and namespaces, e.g. /<controller_manager>/<hardware>/<joint>/<interface>
hardware_interface/include/hardware_interface/loaned_state_interface.hpp
Show resolved
Hide resolved
hardware_interface/include/hardware_interface/loaned_command_interface.hpp
Show resolved
Hide resolved
| return msg; | ||
| } | ||
|
|
||
| void CommandForwarder::subscribe_to_command_publisher(const std::string & topic_name) |
There was a problem hiding this comment.
What's the difference between “command forwarder” and “command publisher”?
| std::flush(std::cout); | ||
|
|
||
| // Put the message into a queue to be processed by the middleware. | ||
| // This call is non-blocking. |
There was a problem hiding this comment.
Shouldn't this be blocking call?
| msg->data = std::numeric_limits<double>::quiet_NaN(); | ||
| } | ||
| RCLCPP_INFO(node_->get_logger(), "Publishing: '%.7lf'", msg->data); | ||
| std::flush(std::cout); |
There was a problem hiding this comment.
Probably not needed?
| std::flush(std::cout); |
| import_command_interfaces(systems_.back()); | ||
| } | ||
|
|
||
| void add_sub_controller_manager( |
There was a problem hiding this comment.
Does resource manager have to know about controller manager? It's a bit convoluted.
* fix typo in StatePublisher (used the pointer which has been moved...) * not a component anymore * collect StatePublishers in map
* export and imprt statepublisher description * initialize DistributedHandle through description * automated generation of node and topic names
* Its not working, since the storage type of command interfaces needs to be changed to std::shared_ptr. This is done in follow_up since should change a lot.
mamueluth
force-pushed
the
distributed_control_poc
branch
from
d3feeaa to
71f4757
Compare
|
This pull request is in conflict. Could you fix it @mamueluth? |
1 similar comment
|
This pull request is in conflict. Could you fix it @mamueluth? |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
|
This pull request is in conflict. Could you fix it @mamueluth? |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
2 participants
No description provided.