Better strings #43
Open
Better strings #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great idea, @yorickreum. Check out #46 which adds support for this and should fit your If it looks alright, we can merge it and close this. |
|
Wow, that was fast. Looks quite good! Way better than my workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not a appropriate fix, more an issue to discuss:
In the JSON we manage with the tool, we have some strings that span multiple lines. This is not supported by the input-field. Hence, in my opinion, it'd be good to switch to textarea.
Or maybe better: Create the possibility to pass own input field components? Would offer much more use cases...
By the way: I think React should be listed as a peer dependency inside the package.json – otherwise you can get in trouble with different mismatching React versions.