This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Add lua and geo* support #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2019
Closed
RicoGit
reviewed
Nov 12, 2019
|
|
||
| fn script_exists<S: Into<MultipleKeys>>(&self, sha1: S) -> Box<Future<Item=Vec<bool>, Error=RedisError>>; | ||
|
|
||
| fn evalsha<S: Into<String>, K: Into<MultipleKeys>, V: Into<MultipleValues>>(&self, sha1: S, keys: K, args: V) -> Box<Future<Item=Vec<RedisValue>, Error=RedisError>>; |
There was a problem hiding this comment.
It should be more readable with where clause.
| RedisCommandKind::ScriptLoad | ||
| | RedisCommandKind::ScriptExists | ||
| | RedisCommandKind::ScriptFlush | ||
| | RedisCommandKind::ScriptKill => true, |
There was a problem hiding this comment.
Maybe EVAL and EVALSHA should be script commands too?
| fn georadius<K: Into<RedisKey>>(&self, key: K, longitude: Longitude, latitude: Latitude, radius: f64, unit: GeoUnit, | ||
| withcoord: bool, withdist: bool, withhash: bool, count: Option<usize>, | ||
| order: Option<GeoOrdering>, store: Option<String>, storedist: Option<String>) | ||
| -> Box<Future<Item=Vec<RedisValue>, Error=RedisError>> |
There was a problem hiding this comment.
Do you use rustfmt? It's brilliant tool.
| @@ -36,7 +36,13 @@ const WITH_SCORES: &'static str = "WITHSCORES"; | |||
| const LIMIT: &'static str = "LIMIT"; | |||
| const AGGREGATE: &'static str = "AGGREGATE"; | |||
| const WEIGHTS: &'static str = "WEIGHTS"; | |||
|
|
|||
| const ASC: &'static str = "ASC"; | |||
There was a problem hiding this comment.
You can skip static for const.
const ASC: &str = "ASC";
| /// Scripts are cached on the server side using the SCRIPT LOAD command. | ||
| /// | ||
| /// <https://redis.io/commands/evalsha> | ||
| fn evalsha<S: Into<String>, K: Into<MultipleKeys>, V: Into<MultipleValues>>(self, sha1: S, keys: K, args: V) -> Box<Future<Item=(Self, Vec<RedisValue>), Error=RedisError>> { |
| @@ -8,6 +8,7 @@ mod pubsub; | |||
| mod sets; | |||
| mod other; | |||
| mod sorted_sets; | |||
| mod geo; | |||
There was a problem hiding this comment.
Why files geo/utils.rs and lua/mod.rs are empty?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.