fix: not working on Windows 10

[starnayuta]

Change the command for running eslint from node.js to npx for compatibility with Windows.

Closes #20

[starnayuta]

The test results are as follows.
I could not determine if this result passed the test.

PS C:\path\to\eslint-cjs-to-esm> node eslint-cjs-to-esm.js "./test-fixtures/*"  

C:\path\to\eslint-cjs-to-esm\test-fixtures\import-index.ts
  1:26  error  require file extension '/index.js'  file-extension-in-import-ts/file-extension-in-import-ts
C:\path\to\eslint-cjs-to-esm\test-fixtures\import-no-js-suffix.ts
  1:8  error  require file extension '.js'  file-extension-in-import-ts/file-extension-in-import-ts
  1:8  error  require file extension '.ts'  node/file-extension-in-import

C:\path\to\eslint-cjs-to-esm\test-fixtures\no-node-protocol.ts
  1:18  error  Prefer `node:path` over `path`  unicorn/prefer-node-protocol

C:\path\to\eslint-cjs-to-esm\test-fixtures\require.ts
  1:1  error  Expected "import" instead of "require()"  import/no-commonjs
  1:1  error  Do not use "require"                      unicorn/prefer-module

✖ 6 problems (6 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

PS C:\path\to\eslint-cjs-to-esm> node eslint-cjs-to-esm.js "./test-fixtures/*" --fix

C:\path\to\eslint-cjs-to-esm\test-fixtures\require.ts
  1:1  error  Expected "import" instead of "require()"  import/no-commonjs
  1:1  error  Do not use "require"                      unicorn/prefer-module

✖ 2 problems (2 errors, 0 warnings)

[azu]

eslint-cjs-to-esm/.github/workflows/test.yml

Lines 5 to 23 in 018695b

	jobs:
	test:
	name: "Test on Node.js ${{ matrix.node-version }}"
	runs-on: ubuntu-latest
	strategy:
	matrix:
	node-version: [ 18,20 ]
	steps:
	- name: checkout
	uses: actions/checkout@v4
	- name: setup Node.js ${{ matrix.node-version }}
	uses: actions/setup-node@v4
	with:
	cache: "npm"
	node-version: ${{ matrix.node-version }}
	- name: Install
	run: npm ci
	- name: Test
	run: npm test

Can you add a matrix?

  test:
    name: Test(Node ${{ matrix.node }} on ${{ matrix.os }})
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [ubuntu-latest, windows-latest]
        node: [ 18, 20 ]

[azu]

https://github.com/azu/eslint-cjs-to-esm/blob/main/package.json#L40
This test confirms that the exit status is 1

[azu]

Another option:

if process are Windows, just add .cmd like this.
https://github.com/saltyshiomix/resolve-as-bin/blob/23908b1c46827f6fd41cdcc401d3d2f5af76eade/index.ts#L13

[starnayuta]

Great. I will try this approach.

Thank you.

Another option:

if process are Windows, just add .cmd like this. https://github.com/saltyshiomix/resolve-as-bin/blob/23908b1c46827f6fd41cdcc401d3d2f5af76eade/index.ts#L13

[starnayuta]

@azu

I changed the implementation and test matrix in the way you explained.

The behaviour is now not changed except in Windows.

[starnayuta]

This error also happened on my local PC.
I am not sure what caused the error, but I will try to check.

https://github.com/azu/eslint-cjs-to-esm/actions/runs/7765836291/job/21181030640?pr=21

[azu]

https://github.com/azu/eslint-cjs-to-esm/actions/runs/7765836291/job/21181030640?pr=21
Ah, This may be expected-exit-status's issue.

We need to run eslint-cjs-to-esm by another way.

[azu]

''node' is not recognized as an internal or external command,

Probably, need to use node.exe or node.cmd in Windows?

[starnayuta]

In cmd, single quote ' seem to be treated as just characters in most cases.
It was changed to double quote ".

https://stackoverflow.com/questions/51080215/differences-between-single-and-double-quotes-in-cmd

[azu]

https://github.com/azu/eslint-cjs-to-esm/actions/runs/7765962449/job/21181296571?pr=21
work on macOS/linux by following change:

- ./test-fixtures/*
+ ./test-fixtures/*.ts

[starnayuta]

Thank you for your kind assistance.

[azu]

Thanks for work!

Release
https://github.com/azu/eslint-cjs-to-esm/releases/tag/v3.0.1 🎉