Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. refactoring and fixes #1838

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Misc. refactoring and fixes #1838

merged 5 commits into from
Jul 14, 2023

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Jul 14, 2023

Overview

This PR makes a few minor changes. See commits for details.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

  • See updated unit tests.

- relocate to core.data.utils.misc
- allow serializing of Box objects
- add unit tests
- remove unused functions from core.utils.misc
- also add/update unit tests
No longer needed after shapely and geopandas version upgrades.
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1838 (f4c7952) into master (3ce9186) will increase coverage by 0.15%.
The diff coverage is 97.88%.

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
+ Coverage   79.88%   80.03%   +0.15%     
==========================================
  Files         188      188              
  Lines        9182     9236      +54     
==========================================
+ Hits         7335     7392      +57     
+ Misses       1847     1844       -3     
Impacted Files Coverage Δ
.../core/data/raster_transformer/stats_transformer.py 85.41% <93.33%> (+8.27%) ⬆️
...ervision_core/rastervision/core/data/utils/misc.py 83.47% <94.44%> (+1.91%) ⬆️
...astervision_core/rastervision/core/raster_stats.py 99.10% <99.00%> (+0.35%) ⬆️
rastervision_core/rastervision/core/box.py 100.00% <100.00%> (ø)
...n/core/data/raster_transformer/cast_transformer.py 100.00% <100.00%> (ø)
...ision/core/evaluation/classification_evaluation.py 96.87% <100.00%> (+4.28%) ⬆️
...stervision_pipeline/rastervision/pipeline/utils.py 80.00% <100.00%> (+8.57%) ⬆️

... and 1 file with indirect coverage changes

@AdeelH AdeelH merged commit f6dcdee into azavea:master Jul 14, 2023
1 check passed
@AdeelH AdeelH deleted the misc branch July 19, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant