This repository has been archived by the owner on Aug 10, 2018. It is now read-only.
Don't override container's entrypoint
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring the Kubernetes executor into line with the Docker executor which never overrides `entrypoint`, but only `cmd` -- in Kubernetes this is done using the `args` parameter instead of the `command` parameter.
|
FYI: I've not been able to test this change at present. I created an automated build on Docker Hub, but this seems to grab pre-built binaries from S3 and there doesn't seem to be a CI configured to build these binaries or instructions for doing it manually. If somebody gives me a steer I should be able to test that this change works in practice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the Kubernetes executor into line with the Docker executor, which never overrides
entrypoint, but onlycmd. In Kubernetes this is done using theargsparameter instead of thecommandparameter.