Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 Crud de curso #10

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

#2 Crud de curso #10

wants to merge 25 commits into from

Conversation

JheannyC
Copy link

@JheannyC JheannyC commented Feb 3, 2021 •
edited by EmersonDantas
Loading

Closes #2

@GhostDovahkiin
Copy link

Jhê, o DTO adiciona uma camada para a entidade Course, então houve um errinho em relação a divisão dos componentes e responsabilidades de cada classe. O @RestController deve ser utilizado em uma classe somente de controller, e não dentro do DTO. Alguns arquivos desnecessários como .idea/ subiram junto do commit, o que não é algo bom pra estrutura do projeto. Dá uma olhada melhor em DTO em alguns projetos aqui do @ayty-org e retira os métodos do controller pra uma classe específica.

Após isso, creio que esteja tudo ok para um merge.
🔥 🔥

@JheannyC JheannyC self-assigned this Feb 5, 2021
waldirmarques
waldirmarques requested changes Feb 5, 2021
View reviewed changes
.idea/compiler.xml Outdated Show resolved Hide resolved
.idea/dataSources.xml Outdated Show resolved Hide resolved
.idea/hatcher-api.iml Outdated Show resolved Hide resolved
.idea/misc.xml Outdated Show resolved Hide resolved
.idea/sqldialects.xml Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/CourseController.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/CourseController.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/exception/ObjectNotFoundException.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/exception/StandardError.java Show resolved Hide resolved
src/main/resources/db/migration/data/V20210205181338__add_course.sql Outdated Show resolved Hide resolved
waldirmarques
waldirmarques requested changes Feb 11, 2021
View reviewed changes
.idea/compiler.xml Outdated Show resolved Hide resolved
.idea/compiler.xml Outdated Show resolved Hide resolved
.idea/dataSources.xml Outdated Show resolved Hide resolved
.idea/dataSources.xml Outdated Show resolved Hide resolved
.idea/hatcher-api.iml Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/CourseController.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/service/CourseService.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/service/CourseService.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/service/CourseService.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/service/CourseService.java Outdated Show resolved Hide resolved
EmersonDantas
EmersonDantas requested changes Feb 13, 2021
View reviewed changes
src/main/java/org/ayty/hatcher/api/v1/course/dto/Course.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/CourseController.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/CourseController.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/CourseController.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/CourseController.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/service/CourseService.java Outdated Show resolved Hide resolved
src/main/java/org/ayty/hatcher/api/v1/course/dto/Course.java Outdated Show resolved Hide resolved
src/main/resources/db/migration/schema/V20210203154851__course_migration.sql Outdated Show resolved Hide resolved
src/test/java/org/ayty/hatcher/api/v1/course/repository/CourseRepositoryTest.java Outdated Show resolved Hide resolved
src/test/java/org/ayty/hatcher/api/v1/course/repository/CourseRepositoryTest.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigor rodrigor rodrigor left review comments

@waldirmarques waldirmarques waldirmarques requested changes

@EmersonDantas EmersonDantas EmersonDantas requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@JheannyC JheannyC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRUD de Curso
5 participants
@JheannyC @GhostDovahkiin @rodrigor @EmersonDantas @waldirmarques