Pin Nerfstudio Version #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I do think the change to make it compatible with the new viewer isn't much. @cvachha can you take a look at this quickly? |
brentyi
added a commit
to nerfstudio-project/nerfstudio
that referenced
this pull request
Jan 19, 2024
brentyi
added a commit
to nerfstudio-project/nerfstudio
that referenced
this pull request
Jan 20, 2024
* fix jittering in markdown in viewer beta * Revert "fix jittering in markdown in viewer beta" This reverts commit 70ade42. * print correctly formatted url in banner for viewer beta * warn when legacy viewerelements are used in new viewer * Add shim for viewer_elements namespace, fixes ayaanzhaque/instruct-nerf2nerf#88 * Fix typo * suppress ruff error --------- Co-authored-by: Brent Yi <[email protected]>
ArpegorPSGH
pushed a commit
to ArpegorPSGH/nerfstudio
that referenced
this pull request
Jun 22, 2024
…oject#2797) * fix jittering in markdown in viewer beta * Revert "fix jittering in markdown in viewer beta" This reverts commit 70ade42. * print correctly formatted url in banner for viewer beta * warn when legacy viewerelements are used in new viewer * Add shim for viewer_elements namespace, fixes ayaanzhaque/instruct-nerf2nerf#88 * Fix typo * suppress ruff error --------- Co-authored-by: Brent Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the latest known working branch of nerfstudio. This helps avoid issues like #85 and #72
Example: nerfstudio viewer was recently updated to use viser, which breaks parts of instruct-nerf2nerf repo.
throws
ModuleNotFoundError: No module named 'nerfstudio.viewer.server'
This PR pins nerfstudio to the commit prior to that update to insure instruct-nerf2nerf installation works out of the box.