Skip to content

refactor: resilient try/catch raise for all workflows #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

refactor: resilient try/catch raise for all workflows #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ef460a
refactor: resilient try/catch raise for all workflows
ivy-rew May 30, 2025
1483f24
wip
ivy-rew May 30, 2025
b6a7ba3
silence stdout
ivy-rew May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/raise-build-plugin-version/raise.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ source "../raiseRepo.sh"
tmpDirectory=$workDir

function updateSingleRepo {
.ivy/raise-build-plugin-version.sh ${releaseVersion} ${snapshotVersion} >> 'maven.log'
.ivy/raise-build-plugin-version.sh ${releaseVersion} ${snapshotVersion} 1>/dev/null
}

function raiseVersionOfOurRepos {
Expand Down
16 changes: 1 addition & 15 deletions build/raise-deps/raise.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,22 +56,8 @@ function raiseDepsOfOurRepos {
runRepoUpdate 'updateSingleRepo' ${repos[@]}
}

raiseErrors=""

function updateSingleRepo {
set +e
{ # try
.ivy/raise-deps.sh ${newVersion}
} || { # catch
skipReason="raise to version ${newVersion} failed!"
raiseErrors+="${repo}: ${skipReason}"
}
set -e
.ivy/raise-deps.sh ${newVersion}
}

raiseDepsOfOurRepos

if ! [ -z "${raiseErrors}" ]; then
echo "Raising of repos failed on some repos: ${raiseErrors}";
exit 127
fi
21 changes: 20 additions & 1 deletion build/raiseRepo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ function runRepoUpdate {
echo " - ${repo}"
done

raiseErrors=""
reposToPush=()

for repo in "${repos[@]}"; do
Expand All @@ -52,7 +53,19 @@ function runRepoUpdate {
git checkout -q -b "${newBranch}"

skipReason=""
${updateAction}

#set +e
{ # try
echo "-----------------> start"
${updateAction}
echo "-----------------> done"
} || { # catch
echo "-----------------> fail"
skipReason="raise action failed!"
raiseErrors+="${repo}: ${skipReason}"
}
#set -e

if [[ -n ${skipReason} ]]; then
echo ""; echo "--> skipping repo '${repo}' because: ${skipReason}";
continue
Expand Down Expand Up @@ -122,4 +135,10 @@ function runRepoUpdate {
echo ""; echo "--> finished pushing repo '${repo}'";
done
cd "${currentDir}"

if ! [ -z "${raiseErrors}" ]; then
echo "Raising of repos failed on some repos: ${raiseErrors}";
exit 127
fi

}